Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 98803004: Pepper: Clean up IDLNode internals. (Closed)

Created:
7 years ago by teravest
Modified:
7 years ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Clean up IDLNode internals. This change simplifies some functions, removes some dead code and fixes up pylint style violations. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238216

Patch Set 1 #

Patch Set 2 : Remove more code #

Patch Set 3 : More dead code removal #

Patch Set 4 : Fix for json_schema_compiler #

Patch Set 5 : Fix potential KeyError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -205 lines) Patch
M ppapi/generators/idl_ast.py View 5 chunks +8 lines, -6 lines 0 comments Download
M ppapi/generators/idl_node.py View 1 2 17 chunks +34 lines, -98 lines 0 comments Download
M ppapi/generators/idl_propertynode.py View 1 2 3 4 5 chunks +17 lines, -100 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
teravest
7 years ago (2013-12-02 15:38:36 UTC) #1
bbudge
lgtm
7 years ago (2013-12-02 17:56:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/98803004/40001
7 years ago (2013-12-02 17:59:22 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=197174
7 years ago (2013-12-02 18:20:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/98803004/60001
7 years ago (2013-12-02 18:27:19 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on mac_rel HTTP Error 400: Bad Request
7 years ago (2013-12-02 19:56:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/98803004/80001
7 years ago (2013-12-02 19:58:11 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-02 23:01:07 UTC) #8
Message was sent while issue was closed. 
Change committed as 238216

Powered by Google App Engine
This is Rietveld 408576698