Source/web/WebLocalFrameImpl.cpp - Issue 988023005: Implementing directional selection strategy in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 988023005: Implementing directional selection strategy in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index caea872adab0f715961a1a565b5980e79acb49b9..b3fc354fccda1138c1c0a4050842029df2c4c9a2 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1248,12 +1248,9 @@ void WebLocalFrameImpl::selectRange(const WebRange& webRange)

frame()->selection().setSelectedRange(range.get(), VP_DEFAULT_AFFINITY, FrameSelection::NonDirectional, NotUserTriggered);

}

-void WebLocalFrameImpl::moveRangeSelectionExtent(const WebPoint& pointInViewport, WebFrame::TextGranularity granularity)

+void WebLocalFrameImpl::moveRangeSelectionExtent(const WebPoint& point)

{

- blink::TextGranularity blinkGranularity = blink::CharacterGranularity;

- if (granularity == WebFrame::WordGranularity)

- blinkGranularity = blink::WordGranularity;

- frame()->selection().moveRangeSelectionExtent(visiblePositionForViewportPoint(pointInViewport), blinkGranularity);

+ frame()->selection().moveRangeSelectionExtent(visiblePositionForViewportPoint(point));

}

void WebLocalFrameImpl::moveRangeSelection(const WebPoint& baseInViewport, const WebPoint& extentInViewport, WebFrame::TextGranularity granularity)

« no previous file with comments | « Source/web/WebLocalFrameImpl.h ('k') | Source/web/WebSettingsImpl.h » ('j') | no next file with comments »