Implementing directional selection strategy in Blink.

Source/core/editing/VisibleSelection.h

 /*
  * Copyright (C) 2004 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef VisibleSelection_h
 #define VisibleSelection_h
 
 #include "core/CoreExport.h"
 #include "core/editing/SelectionType.h"
 #include "core/editing/TextGranularity.h"
 #include "core/editing/VisiblePosition.h"
+#include "core/editing/VisibleUnits.h"
 
 namespace blink {
 
 class LayoutPoint;
 class Position;
 
 const EAffinity SEL_DEFAULT_AFFINITY = DOWNSTREAM;
 enum SelectionDirection { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft };
 
 class CORE_EXPORT VisibleSelection {
@@ skipping 96 matching lines @@
     DECLARE_TRACE();
 
     void validatePositionsIfNeeded();
 
 #ifndef NDEBUG
     void debugPosition() const;
     void formatForDebugger(char* buffer, unsigned length) const;
     void showTreeForThis() const;
 #endif
 
-    void setStartRespectingGranularity(TextGranularity);
-    void setEndRespectingGranularity(TextGranularity);
+    void setStartRespectingGranularity(TextGranularity, EWordSide defaultWordSide = RightWordIfOnBoundary);
+    void setEndRespectingGranularity(TextGranularity, EWordSide defaultWordSide = RightWordIfOnBoundary);
 
 private:
     void validate(TextGranularity = CharacterGranularity);
 
     // Support methods for validate()
     void setBaseAndExtentToDeepEquivalents();
     void adjustSelectionToAvoidCrossingShadowBoundaries();
     void adjustSelectionToAvoidCrossingEditingBoundaries();
     void updateSelectionType();
 
@@ skipping 15 matching lines @@
 
     // these are cached, can be recalculated by validate()
     SelectionType m_selectionType; // None, Caret, Range
     bool m_baseIsFirst : 1; // True if base is before the extent
     bool m_isDirectional : 1; // Non-directional ignores m_baseIsFirst and selection always extends on shift + arrow key.
 };
 
 inline bool operator==(const VisibleSelection& a, const VisibleSelection& b)
 {
     return a.start() == b.start() && a.end() == b.end() && a.affinity() == b.affinity() && a.isBaseFirst() == b.isBaseFirst()
-        && a.isDirectional() == b.isDirectional();
+        && a.isDirectional() == b.isDirectional() && a.base() == b.base() && a.extent() == b.extent();

[yosin_UTC9, 2015/04/16 04:11:26]

Note: I assume this change will be kicked out from this patch, since another
patch has this change.

[mfomitchev1, 2015/04/17 00:13:51]

Done.

 }
 
 inline bool operator!=(const VisibleSelection& a, const VisibleSelection& b)
 {
     return !(a == b);
 }
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::VisibleSelection&);
 void showTree(const blink::VisibleSelection*);
 #endif
 
 #endif // VisibleSelection_h