content/browser/devtools/shared_worker_devtools_manager.h - Issue 988003002: DevTools: pick sw targets to attach to on the backend side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/shared_worker_devtools_manager.h

Issue 988003002: DevTools: pick sw targets to attach to on the backend side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/shared_worker_devtools_agent_host.h ('k') | content/browser/devtools/shared_worker_devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/shared_worker_devtools_manager.h

diff --git a/content/browser/devtools/shared_worker_devtools_manager.h b/content/browser/devtools/shared_worker_devtools_manager.h

index 4e5af855ac93cabfefac6ec7fbd87cf4c4644889..6a2a828f9bfda49fa3cc65b39519526bd4ae3a5a 100644

--- a/content/browser/devtools/shared_worker_devtools_manager.h

+++ b/content/browser/devtools/shared_worker_devtools_manager.h

@@ -22,14 +22,15 @@ class SharedWorkerInstance;

// This class lives on UI thread.

class CONTENT_EXPORT SharedWorkerDevToolsManager {

public:

- typedef std::pair<int, int> WorkerId;

+ using WorkerId = std::pair<int, int>;

// Returns the SharedWorkerDevToolsManager singleton.

static SharedWorkerDevToolsManager* GetInstance();

DevToolsAgentHostImpl* GetDevToolsAgentHostForWorker(int worker_process_id,

int worker_route_id);

- void AddAllAgentHosts(DevToolsAgentHost::List* result);

+ void AddAllAgentHosts(

+ std::vector<scoped_refptr<SharedWorkerDevToolsAgentHost>>* result);

// Returns true when the worker must be paused on start because a DevTool

// window for the same former SharedWorkerInstance is still opened.