Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: content/browser/devtools/service_worker_devtools_manager.h

Issue 988003002: DevTools: pick sw targets to attach to on the backend side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/service_worker_devtools_manager.h
diff --git a/content/browser/devtools/service_worker_devtools_manager.h b/content/browser/devtools/service_worker_devtools_manager.h
index ecb3712d9e04f9e8168e7d31230b3f02b2f4c645..9d3cf4540987ad300cb292aac7389a7ae393dbb5 100644
--- a/content/browser/devtools/service_worker_devtools_manager.h
+++ b/content/browser/devtools/service_worker_devtools_manager.h
@@ -23,12 +23,15 @@ class ServiceWorkerContextCore;
// This class lives on UI thread.
class CONTENT_EXPORT ServiceWorkerDevToolsManager {
public:
- typedef std::pair<int, int> WorkerId;
+ using WorkerId = std::pair<int, int>;
+ using AgentList = std::vector<scoped_refptr<ServiceWorkerDevToolsAgentHost>>;
class Observer {
public:
- virtual void WorkerCreated(DevToolsAgentHost* host) {}
- virtual void WorkerDestroyed(DevToolsAgentHost* host) {}
+ virtual void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) {}
+ virtual void WorkerReadyForInspection(
+ ServiceWorkerDevToolsAgentHost* host) {}
+ virtual void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) {}
protected:
virtual ~Observer() {}
@@ -65,7 +68,8 @@ class CONTENT_EXPORT ServiceWorkerDevToolsManager {
DevToolsAgentHostImpl* GetDevToolsAgentHostForWorker(int worker_process_id,
int worker_route_id);
- void AddAllAgentHosts(DevToolsAgentHost::List* result);
+ void AddAllAgentHosts(
+ std::vector<scoped_refptr<ServiceWorkerDevToolsAgentHost>>* result);
// Returns true when the worker must be paused on start because a DevTool
// window for the same former ServiceWorkerIdentifier is still opened or

Powered by Google App Engine
This is Rietveld 408576698