Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 988003002: DevTools: pick sw targets to attach to on the backend side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index 0a9c19367f51ed87f4beb7ce060958e861f3b61b..147925e8214fa82646d593964470591d96455a47 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -13,6 +13,9 @@
#include "content/public/browser/devtools_agent_host_client.h"
namespace content {
+
+class ServiceWorkerDevToolsAgentHost;
+
namespace devtools {
namespace service_worker {
@@ -25,6 +28,7 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
~ServiceWorkerHandler() override;
void SetClient(scoped_ptr<Client> client);
+ void SetURL(const GURL& url);
void Detached();
// Protocol 'service worker' domain implementation.
@@ -32,12 +36,12 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
Response Disable();
Response SendMessage(const std::string& worker_id,
const std::string& message);
- Response Attach(const std::string& worker_id);
- Response Detach(const std::string& worker_id);
+ Response Stop(const std::string& worker_id);
// WorkerDevToolsManager::Observer implementation.
- void WorkerCreated(DevToolsAgentHost* host) override;
- void WorkerDestroyed(DevToolsAgentHost* host) override;
+ void WorkerCreated(ServiceWorkerDevToolsAgentHost* host) override;
+ void WorkerReadyForInspection(ServiceWorkerDevToolsAgentHost* host) override;
+ void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) override;
private:
// DevToolsAgentHostClient overrides.
@@ -46,10 +50,16 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
void AgentHostClosed(DevToolsAgentHost* agent_host,
bool replaced_with_another_client) override;
+ void ReportWorkerCreated(DevToolsAgentHost* host, bool new_worker);
+
+ bool MatchesInspectedPage(ServiceWorkerDevToolsAgentHost* host);
+
scoped_ptr<Client> client_;
- using AttachedHosts = std::map<std::string,
- scoped_refptr<DevToolsAgentHost>>;
+ using AttachedHosts = std::map<
+ std::string, scoped_refptr<ServiceWorkerDevToolsAgentHost>>;
AttachedHosts attached_hosts_;
+ bool enabled_;
+ GURL url_;
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerHandler);
};
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698