Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 987963002: Add forgetNetwork to networkingPrivate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add to chrome_extensions.js Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
index 89c2f77bee61619e7edbbccf5f24dd9ec354e978..1abc07b10a572f4736b4e2487b80c89816a413ed 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
@@ -71,6 +71,12 @@ class TestDelegate : public NetworkingPrivateDelegate {
StringResult(success_callback, failure_callback);
}
+ void ForgetNetwork(const std::string& guid,
+ const VoidCallback& success_callback,
+ const FailureCallback& failure_callback) override {
+ VoidResult(success_callback, failure_callback);
+ }
+
void GetNetworks(const std::string& network_type,
bool configured_only,
bool visible_only,
@@ -331,6 +337,10 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, CreateNetwork) {
EXPECT_TRUE(RunNetworkingSubtest("createNetwork")) << message_;
}
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, ForgetNetwork) {
+ EXPECT_TRUE(RunNetworkingSubtest("createNetwork")) << message_;
pneubeck (no reviews) 2015/03/16 10:14:57 wrong test, should call 'forgetNetwork'
stevenjb 2015/03/20 16:52:27 Oops. Done.
+}
+
IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, GetNetworks) {
EXPECT_TRUE(RunNetworkingSubtest("getNetworks")) << message_;
}
@@ -420,6 +430,10 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, CreateNetwork) {
EXPECT_FALSE(RunNetworkingSubtest("createNetwork")) << message_;
}
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, ForgetNetwork) {
+ EXPECT_FALSE(RunNetworkingSubtest("createNetwork")) << message_;
pneubeck (no reviews) 2015/03/16 10:14:57 wrong test, should call 'forgetNetwork'
stevenjb 2015/03/20 16:52:27 Done.
+}
+
IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, GetNetworks) {
EXPECT_FALSE(RunNetworkingSubtest("getNetworks")) << message_;
}

Powered by Google App Engine
This is Rietveld 408576698