base/base.gyp - Issue 987943002: Fix SysStrings unit test failure on Chromecast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 987943002: Fix SysStrings unit test failure on Chromecast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moving SYSTEM_NATIVE_UTF8 setup to base_unittest gyp target Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index aa77264c6666114acd44e338c0018c83e554b9aa..3b2f71a736c59187f60a25509d6a9d71d4d125ec 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -843,6 +843,11 @@

['include', '^debug/proc_maps_linux_unittest\\.cc$'],

}],

+ # Enable more direct string conversions on platforms with native utf8

+ # strings

+ ['OS=="mac" or OS=="ios" or <(chromeos)==1 or <(chromecast)==1', {

+ 'defines': ['SYSTEM_NATIVE_UTF8'],

+ }],

], # target_conditions

{

« no previous file with comments | « base/BUILD.gn ('k') | base/strings/sys_string_conversions_unittest.cc » ('j') | no next file with comments »