Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: content/public/browser/navigation_type.h

Issue 987923002: Add tests for navigation type classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@subframe
Patch Set: docs Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_type.h
diff --git a/content/public/browser/navigation_type.h b/content/public/browser/navigation_type.h
index 01431cd0244bdb35210e5093a24aedf97051365d..9253f526ba945805dad503b67cd1238515631f2f 100644
--- a/content/public/browser/navigation_type.h
+++ b/content/public/browser/navigation_type.h
@@ -13,11 +13,15 @@ enum NavigationType {
// Unknown type.
NAVIGATION_TYPE_UNKNOWN,
- // A new page was navigated in the main frame.
+ // A new page was navigated to in the main frame. This covers all cases where
+ // the main frame navigated and a new navigation entry was created. This means
+ // cases like navigations to a hash on the same page are NEW_PAGE, not
+ // IN_PAGE. (Navigation entries created by subframe navigations are
+ // NEW_SUBFRAME.)
NAVIGATION_TYPE_NEW_PAGE,
- // Renavigating to an existing navigation entry. The entry is guaranteed to
- // exist in the list, or else it would be a new page or IGNORE navigation.
+ // Renavigating to an existing navigation entry. This is the case for history
+ // navigation, reloads, and location.replace().
NAVIGATION_TYPE_EXISTING_PAGE,
// The same page has been reloaded as a result of the user requesting
@@ -26,10 +30,10 @@ enum NavigationType {
// pending entry for the load, which is then meaningless.
NAVIGATION_TYPE_SAME_PAGE,
- // In page navigations are when the reference fragment changes. This will
- // be in the main frame only (we won't even get notified of in-page
- // subframe navigations). It may be for any page, not necessarily the last
Charlie Reis 2015/03/09 23:28:26 Man, that last sentence was confusing. It sounds
- // committed one (for example, whey going back to a page with a ref).
+ // The navigation was in the main frame, to a different navigation entry, but
+ // appearing to the user to be a navigation within the same page. This is the
+ // case for history.replaceState(), and back and forward across fragment
Charlie Reis 2015/03/09 23:28:26 nit: s/and/as well as/ (just to better divide the
+ // entries and history.pushState() entries.
NAVIGATION_TYPE_IN_PAGE,
// A new subframe was manually navigated by the user. We will create a new

Powered by Google App Engine
This is Rietveld 408576698