Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 987923002: Add tests for navigation type classifications. (Closed)

Created:
5 years, 9 months ago by Avi (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@subframe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for navigation type classifications. BUG=369661 TEST=no code changes; this adds new tests Committed: https://crrev.com/1d07590021ab4b5781cefa1595d297ccf475d7fe Cr-Commit-Position: refs/heads/master@{#319894}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 11

Patch Set 3 : creis #

Total comments: 2

Patch Set 4 : docs #

Total comments: 2

Patch Set 5 : small creis tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -29 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 3 16 chunks +291 lines, -22 lines 0 comments Download
M content/public/browser/navigation_type.h View 1 2 3 4 2 chunks +11 lines, -7 lines 0 comments Download
A content/test/data/navigation_controller/page_with_links.html View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Avi (use Gerrit)
Everything but the client-side redirects. That's the next CL.
5 years, 9 months ago (2015-03-06 23:49:13 UTC) #2
Charlie Reis
A few thoughts on the things we've been confused about so far. https://codereview.chromium.org/987923002/diff/20001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc ...
5 years, 9 months ago (2015-03-09 20:39:58 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/987923002/diff/20001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/987923002/diff/20001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode324 content/browser/frame_host/navigation_controller_impl_browsertest.cc:324: // TODO(avi,creis): Why is this not NAVIGATION_TYPE_IN_PAGE? It makes ...
5 years, 9 months ago (2015-03-09 21:35:56 UTC) #4
Charlie Reis
New tests (and remaining questions to answer) LGTM. Do you want to make some updates ...
5 years, 9 months ago (2015-03-09 22:04:05 UTC) #5
Avi (use Gerrit)
PTAL https://codereview.chromium.org/987923002/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc File content/browser/frame_host/navigation_controller_impl_browsertest.cc (right): https://codereview.chromium.org/987923002/diff/40001/content/browser/frame_host/navigation_controller_impl_browsertest.cc#newcode480 content/browser/frame_host/navigation_controller_impl_browsertest.cc:480: // TODO(avi,creis): Huh? Why is this not NAVIGATION_TYPE_EXISTING_PAGE ...
5 years, 9 months ago (2015-03-09 22:50:19 UTC) #6
Charlie Reis
Thanks, LGTM. https://codereview.chromium.org/987923002/diff/60001/content/public/browser/navigation_type.h File content/public/browser/navigation_type.h (left): https://codereview.chromium.org/987923002/diff/60001/content/public/browser/navigation_type.h#oldcode31 content/public/browser/navigation_type.h:31: // subframe navigations). It may be for ...
5 years, 9 months ago (2015-03-09 23:28:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987923002/80001
5 years, 9 months ago (2015-03-10 14:25:10 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-10 16:06:51 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 16:07:38 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1d07590021ab4b5781cefa1595d297ccf475d7fe
Cr-Commit-Position: refs/heads/master@{#319894}

Powered by Google App Engine
This is Rietveld 408576698