Upstream Layout.java and associated files

Upstream Layout.java and associated files

Start upstreaming Layout/LayoutManager files.

BUG=428821
Committed: https://crrev.com/ac264414398335718c0df710956cbfb965b5f5cf
Cr-Commit-Position: refs/heads/master@{#319769}

[David Trainor- moved to gerrit, 2015-03-06 22:19:01]

dtrainor@chromium.org changed reviewers:
+ donnd@chromium.org, pedrosimonetti@chromium.org, yfriedman@chromium.org

[David Trainor- moved to gerrit, 2015-03-06 22:19:02]

Upstreaming CL.  This change encompasses moves, import changes, and javadoc
fixes.

yfriedman: all
pedrosimonetti/donnd: contextual search file locations

[Donn Denman, 2015-03-06 22:36:42]

On 2015/03/06 22:19:02, David Trainor wrote:
> Upstreaming CL.  This change encompasses moves, import changes, and javadoc
> fixes.
> 
> yfriedman: all
> pedrosimonetti/donnd: contextual search file locations

lgtm for file locations.  Thanks David!

[Yaron, 2015-03-06 22:57:08]

lgtm

It probably makes sense to have someone more familiar with the UI layer to
approve. This is a straight move from internal tree but I have a hard time
telling if this would make things confusing in the short term while stuff is
still coming up. Ask newt/ted?

https://codereview.chromium.org/987883002/diff/20001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/AndroidMathUtils.java (right):

https://codereview.chromium.org/987883002/diff/20001/base/android/java/src/or...
base/android/java/src/org/chromium/base/AndroidMathUtils.java:10: public class
AndroidMathUtils {
There's already a MathUtils class in org.chromium.chrome.browser.util; Can you
put this there?

[David Trainor- moved to gerrit, 2015-03-09 01:09:27]

dtrainor@chromium.org changed reviewers:
+ changwan@chromium.org

[Yaron, 2015-03-09 14:23:40]

https://codereview.chromium.org/987883002/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutUpdateHost.java
(right):

https://codereview.chromium.org/987883002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutUpdateHost.java:49:
* {@link com.google.android.apps.chrome.tab.ChromeTab}.
Change to Tab

https://codereview.chromium.org/987883002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutUpdateHost.java:53:
*              to be initialized from a {@link
com.google.android.apps.chrome.tab.ChromeTab}.
Here too

[David Trainor- moved to gerrit, 2015-03-09 20:02:42]

https://chromiumcodereview.appspot.com/987883002/diff/20001/base/android/java...
File base/android/java/src/org/chromium/base/AndroidMathUtils.java (right):

https://chromiumcodereview.appspot.com/987883002/diff/20001/base/android/java...
base/android/java/src/org/chromium/base/AndroidMathUtils.java:10: public class
AndroidMathUtils {
On 2015/03/06 22:57:08, Yaron wrote:
> There's already a MathUtils class in org.chromium.chrome.browser.util; Can you
> put this there?

Done.

https://chromiumcodereview.appspot.com/987883002/diff/40001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutUpdateHost.java
(right):

https://chromiumcodereview.appspot.com/987883002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutUpdateHost.java:49:
* {@link com.google.android.apps.chrome.tab.ChromeTab}.
On 2015/03/09 14:23:39, Yaron wrote:
> Change to Tab

Done.

https://chromiumcodereview.appspot.com/987883002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutUpdateHost.java:53:
*              to be initialized from a {@link
com.google.android.apps.chrome.tab.ChromeTab}.
On 2015/03/09 14:23:39, Yaron wrote:
> Here too

Done.

[David Trainor- moved to gerrit, 2015-03-09 21:26:31]

dtrainor@chromium.org changed reviewers:
+ klundberg@chromium.org

[David Trainor- moved to gerrit, 2015-03-09 21:26:32]

klundberg@: Can you please take a look at
build/android/findbugs_filter/findbugs_exclude.xml?  I needed to move this from
the downstream one as I upstream these files.

Thanks!

[Yaron, 2015-03-09 21:32:56]

https://chromiumcodereview.appspot.com/987883002/diff/100001/build/android/fi...
File build/android/findbugs_filter/findbugs_exclude.xml (right):

https://chromiumcodereview.appspot.com/987883002/diff/100001/build/android/fi...
build/android/findbugs_filter/findbugs_exclude.xml:26: <Class
name="org.chromium.chrome.browser.compositor.layouts.Layout" />
Can you just use SuppressFBWarnings instead?

[David Trainor- moved to gerrit, 2015-03-09 22:07:45]

https://chromiumcodereview.appspot.com/987883002/diff/100001/build/android/fi...
File build/android/findbugs_filter/findbugs_exclude.xml (right):

https://chromiumcodereview.appspot.com/987883002/diff/100001/build/android/fi...
build/android/findbugs_filter/findbugs_exclude.xml:26: <Class
name="org.chromium.chrome.browser.compositor.layouts.Layout" />
On 2015/03/09 21:32:55, Yaron wrote:
> Can you just use SuppressFBWarnings instead?

Oh forgot we have that.  Thanks :).

[David Trainor- moved to gerrit, 2015-03-09 22:48:39]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-03-09 22:48:40]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/987883002/#ps120001
(title: "Move to SuppressFBWarnings from findbugs_exclude.xml")

[commit-bot: I haz the power, 2015-03-09 22:49:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/987883002/120001

[commit-bot: I haz the power, 2015-03-09 23:35:16]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-03-09 23:37:34]

Patchset 7 (id:??) landed as
https://crrev.com/ac264414398335718c0df710956cbfb965b5f5cf
Cr-Commit-Position: refs/heads/master@{#319769}