Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 987833002: add some more sky api to fakesky stub implementation. (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

add some more sky api to fakesky stub implementation. TBR=eseidel BUG= Committed: https://chromium.googlesource.com/external/mojo/+/e8b1c2df7a43848f07cccd3c8ec6f1d4a7e6956d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M sky/examples/fn/lib/fakesky.dart View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
rafaelw
Committed patchset #1 (id:1) manually as e8b1c2df7a43848f07cccd3c8ec6f1d4a7e6956d (presubmit successful).
5 years, 9 months ago (2015-03-06 20:46:13 UTC) #1
abarth-chromium
5 years, 9 months ago (2015-03-06 21:42:14 UTC) #3
Message was sent while issue was closed.
Random thought: Should we move fakesky to //sky/benchmarks ?

Powered by Google App Engine
This is Rietveld 408576698