Source/bindings/v8/custom/V8TextTrackCueCustom.cpp - Issue 98783003: Make HTMLOptionsCollection report TypeErrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

Issue 98783003: Make HTMLOptionsCollection report TypeErrors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp ('k') | Source/core/html/HTMLOptionsCollection.cpp » ('j') | Source/core/html/HTMLOptionsCollection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

diff --git a/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp b/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

index 905b2f3c91744cc98ad62bb1481e169110beee7e..382c15e705b5aeacc27e2c787ad6927dd2049122 100644

--- a/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

+++ b/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

@@ -45,7 +45,7 @@ v8::Handle<v8::Value> toV8(TextTrackCue* impl, v8::Handle<v8::Object> creationCo

void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

if (UNLIKELY(info.Length() < 3)) {

- throwTypeError(ExceptionMessages::failedToExecute("Constructor", "TextTrackCue", ExceptionMessages::notEnoughArguments(3, info.Length())), info.GetIsolate());

Mike West 2013/12/02 11:18:13 This needs a test (which is the worst part of upda

sof 2013/12/02 11:47:58 Done.

+ throwTypeError(ExceptionMessages::failedToConstruct("TextTrackCue", ExceptionMessages::notEnoughArguments(3, info.Length())), info.GetIsolate());

return;

}

V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue()));