Issue 987823003: Code cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987823003: Code cleanup. (Closed)

Created:
5 years, 9 months ago by Bence

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Code cleanup. Reorder members for better packing in memory. Fix indentation. Remove redundant private: keyword. Remove trivial test. This CL lands server change 87638916 by birenroy. BUG= Committed: https://crrev.com/465df415da20f8b475785ad499d36446d7c6908c Cr-Commit-Position: refs/heads/master@{#319632}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -19 lines)			Patch
M	net/spdy/spdy_framer.h	View	5 chunks	+12 lines, -11 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987823003/1

5 years, 9 months ago (2015-03-09 14:27:27 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 15:23:44 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/465df415da20f8b475785ad499d36446d7c6908c
Cr-Commit-Position: refs/heads/master@{#319632}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages