Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 987793002: Update DOM Distiller roll script DEPS in out/package. (Closed)

Created:
5 years, 9 months ago by nyquist
Modified:
5 years, 9 months ago
Reviewers:
cjhopman, Cait (Slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DOM Distiller roll script DEPS in out/package. Update roll-script to DEPS in the package instead of checking it in. The new package folder lives at a new place to ensure there are no issues when rolling back or forward from this CL. The new location is: //third_party/dom_distiller_js/dist. After running `ant package`, the roll-script now takes the content from out/package and pushes it to an external repository on GitHub (chromium/dom-distiller-dist) and updates DEPS for that repo to refer to the newly pushed version. BUG=467787 Committed: https://crrev.com/bbd665a562ee29ce0f7ef0c18aa300830965db17 Cr-Commit-Position: refs/heads/master@{#321576}

Patch Set 1 #

Patch Set 2 : Added .gitignore entry for test_package #

Patch Set 3 : DEPS in all of package #

Total comments: 7

Patch Set 4 : Changed to using 'dist', and also checking old version and diff-link #

Patch Set 5 : Updated grit to understand android webview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1077 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M components/dom_distiller/core/javascript/domdistiller.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/resources/components_resources.grd View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M third_party/dom_distiller_js/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/dom_distiller_js/dom_distiller_js.gyp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/dom_distiller_js/package/js/domdistiller.js View 1 2 1 chunk +0 lines, -178 lines 0 comments Download
D third_party/dom_distiller_js/package/proto/dom_distiller.proto View 1 2 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h View 1 2 1 chunk +0 lines, -772 lines 0 comments Download
M third_party/dom_distiller_js/update_domdistiller_js.sh View 1 2 3 3 chunks +35 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
nyquist
cjhopman: PTAL I have not created the repo yet, so before this is submitted I ...
5 years, 9 months ago (2015-03-06 18:53:05 UTC) #2
nyquist
cjhopman: friendly ping
5 years, 9 months ago (2015-03-12 00:32:04 UTC) #3
cjhopman
https://codereview.chromium.org/987793002/diff/40001/DEPS File DEPS (right): https://codereview.chromium.org/987793002/diff/40001/DEPS#newcode291 DEPS:291: 'src/third_party/dom_distiller_js/package': I think you're less likely to run into ...
5 years, 9 months ago (2015-03-12 02:12:22 UTC) #4
nyquist
cjhopman: PTAL. Addressed all comments. Also now I have pushed the current version to https://github.com/chromium/dom-distiller-dist ...
5 years, 9 months ago (2015-03-17 00:46:22 UTC) #5
nyquist
https://codereview.chromium.org/987793002/diff/40001/third_party/dom_distiller_js/update_domdistiller_js.sh File third_party/dom_distiller_js/update_domdistiller_js.sh (right): https://codereview.chromium.org/987793002/diff/40001/third_party/dom_distiller_js/update_domdistiller_js.sh#newcode79 third_party/dom_distiller_js/update_domdistiller_js.sh:79: echo "Picked up changes:" On 2015/03/17 at 00:46:22, nyquist ...
5 years, 9 months ago (2015-03-17 00:47:30 UTC) #6
cjhopman
lgtm
5 years, 9 months ago (2015-03-19 03:27:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987793002/60001
5 years, 9 months ago (2015-03-19 21:36:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/69408)
5 years, 9 months ago (2015-03-19 21:51:22 UTC) #11
nyquist
caitkp: PTAL //components/resources/components_resources.grd
5 years, 9 months ago (2015-03-20 00:59:18 UTC) #13
Cait (Slow)
lgtm
5 years, 9 months ago (2015-03-20 15:08:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987793002/80001
5 years, 9 months ago (2015-03-20 15:39:10 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-20 16:20:30 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 16:21:20 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bbd665a562ee29ce0f7ef0c18aa300830965db17
Cr-Commit-Position: refs/heads/master@{#321576}

Powered by Google App Engine
This is Rietveld 408576698