Fix for subscribing for notifications for files in packages.

pkg/analysis_server/test/mock_sdk.dart

Index: pkg/analysis_server/test/mock_sdk.dart
diff --git a/pkg/analysis_server/test/mock_sdk.dart b/pkg/analysis_server/test/mock_sdk.dart
index 19679949589216055fef65a1841630243843d109..504ecd97cba53fe4733a692b61b3ea532f8cc2d8 100644
--- a/pkg/analysis_server/test/mock_sdk.dart
+++ b/pkg/analysis_server/test/mock_sdk.dart
@@ -223,10 +223,9 @@ class HtmlElement {}
     for (SdkLibrary library in LIBRARIES) {
       String libraryPath = library.path;
       if (filePath.replaceAll('\\', '/') == libraryPath) {
-        String path = library.shortName;
         try {
           resource.File file = provider.getResource(uri.path);
-          Uri dartUri = new Uri(scheme: 'dart', path: path);
+          Uri dartUri = Uri.parse(library.shortName);

[Brian Wilkerson, 2015/03/06 15:04:27]

I would have expected, based on the old code, that the short name did not
include the "dart:" scheme. I seems like we need to add that in order for the
URI to be correct.

[scheglov, 2015/03/06 21:47:03]

The comment in SdkLibrary says:

  /**
   * Return the short name of the library. This is the URI of the library,
including `dart:`.
   *
   * @return the short name of the library
   */
  String get shortName;

  MockSdk libraries follow this requirement.

  As I can see, SdkLibrariesReader_LibraryBuilder also appends _LIBRARY_PREFIX
(i.e. dart:) to the names it reads from libraries.dart file.

[Paul Berry, 2015/03/06 22:04:45]

I think Konstantin's analysis is correct.  However, there's a misleading comment
on SdkLibraryImpl._shortName, which claims that it *doesn't* include "dart:"  As
far as I can tell, it always does include "dart:".

           return file.createSource(dartUri);
         } catch (exception) {
           return null;