Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 98763004: Cleanups for VTTTokenizer (Closed)

Created:
7 years ago by fs
Modified:
7 years ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Cleanups for VTTTokenizer Get rid of VTTTokenizer::m_token, and hence remove the need to play games with pointers to the resulting token, since the token is now produced at the end of VTTTokenizer::nextToken. This renders the reset() method empty (and it wasn't previously used outside of VTTTokenizer), so remove it. Make a local, tailored, version of the ADVANCE_TO macro to get rid of the redundant check of advance(). This in turn allows removing the (now useless) part of the scaffolding which is haveBufferedCharacterToken(), as well as turning VTTTokenizer::m_state into the local 'state' and moving the definition of the state enumeration into the cpp-file. This also means the state defintions can be moved from the header-file, so do that as well. BUG=319391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -72 lines) Patch
M Source/core/html/track/vtt/VTTTokenizer.h View 1 chunk +1 line, -42 lines 0 comments Download
M Source/core/html/track/vtt/VTTTokenizer.cpp View 11 chunks +43 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
7 years ago (2013-12-02 14:29:47 UTC) #1
Mike West
This looks significantly simpler than the current setup, and means that we don't have to ...
7 years ago (2013-12-02 14:45:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/98763004/1
7 years ago (2013-12-02 15:10:57 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 16:08:14 UTC) #4
Message was sent while issue was closed.
Change committed as 162994

Powered by Google App Engine
This is Rietveld 408576698