Issue 987613002: Make stocksapp.dart almost pass the dart analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987613002: Make stocksapp.dart almost pass the dart analyzer. (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make stocksapp.dart almost pass the dart analyzer. To test: sky/tools/shelldb analyze sky/examples/stocks-fn/stocksapp.dart It prints 600+ warnings about the "native" keyword, and after this change only a couple warnings about missing library names which I don't fully understand. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7e182bc8d227ec9465efa60e145792f288db2478

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	sky/examples/fn/widgets/fixedheightscrollable.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sky/examples/fn/widgets/material.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/stocks-fn/stocksapp.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/framework/fn.dart	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 9 months ago (2015-03-06 00:52:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e182bc8d227ec9465efa60e145792f288db2478 (presubmit successful).