Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 987603003: bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests (Closed)

Created:
5 years, 9 months ago by mdempsky
Modified:
5 years, 9 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests [Reland of https://codereview.chromium.org/940693004] Previously they were more like integration tests that relied on seccomp-bpf for installing the policies and executing them via live system calls. BUG=449357 Committed: https://crrev.com/bdc0f56e733a3fe99ab06670bd698d6880315fa4 Cr-Commit-Position: refs/heads/master@{#319537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -79 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 9 chunks +150 lines, -75 lines 0 comments Download
M sandbox/linux/bpf_dsl/seccomp_macros.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/trap_registry.h View 1 chunk +4 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/verifier.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mdempsky
5 years, 9 months ago (2015-03-06 21:41:00 UTC) #2
jln (very slow on Chromium)
Rubberstamp lgtm based on previous review.
5 years, 9 months ago (2015-03-06 21:53:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987603003/1
5 years, 9 months ago (2015-03-06 21:53:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-07 00:24:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:25:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdc0f56e733a3fe99ab06670bd698d6880315fa4
Cr-Commit-Position: refs/heads/master@{#319537}

Powered by Google App Engine
This is Rietveld 408576698