Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_event_router.cc

Issue 987583004: Add audible, muted to Tab, c.t.query, c.t.update, and c.t.onUpdated where relevant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch1
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
index 5c187402a2778f007e44130141624c6594ad5c9f..abf5243e991e0bd01abc97214ddd362cb3bed561 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/extensions/api/tabs/tabs_event_router.h"
+#include "base/command_line.h"
#include "base/json/json_writer.h"
#include "base/values.h"
#include "chrome/browser/chrome_notification_types.h"
@@ -16,6 +17,8 @@
#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/tabs/tab_utils.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "components/favicon/content/content_favicon_driver.h"
#include "content/public/browser/favicon_status.h"
@@ -59,40 +62,58 @@ bool WillDispatchTabUpdatedEvent(
} // namespace
-TabsEventRouter::TabEntry::TabEntry() : complete_waiting_on_load_(false),
- url_() {
+TabsEventRouter::TabEntry::TabEntry(content::WebContents* contents)
+ : contents_(contents),
+ complete_waiting_on_load_(false),
+ was_audible_(contents->WasRecentlyAudible()),
+ was_muted_(contents->IsAudioMuted()) {
}
-base::DictionaryValue* TabsEventRouter::TabEntry::UpdateLoadState(
- const WebContents* contents) {
+scoped_ptr<base::DictionaryValue> TabsEventRouter::TabEntry::UpdateLoadState() {
// The tab may go in & out of loading (for instance if iframes navigate).
// We only want to respond to the first change from loading to !loading after
// the NAV_ENTRY_COMMITTED was fired.
- if (!complete_waiting_on_load_ || contents->IsLoading())
- return NULL;
+ scoped_ptr<base::DictionaryValue> changed_properties(
+ new base::DictionaryValue());
+ if (!complete_waiting_on_load_ || contents_->IsLoading()) {
+ return changed_properties.Pass();
+ }
// Send "complete" state change.
complete_waiting_on_load_ = false;
- base::DictionaryValue* changed_properties = new base::DictionaryValue();
changed_properties->SetString(tabs_constants::kStatusKey,
tabs_constants::kStatusValueComplete);
- return changed_properties;
+ return changed_properties.Pass();
}
-base::DictionaryValue* TabsEventRouter::TabEntry::DidNavigate(
- const WebContents* contents) {
+scoped_ptr<base::DictionaryValue> TabsEventRouter::TabEntry::DidNavigate() {
// Send "loading" state change.
complete_waiting_on_load_ = true;
- base::DictionaryValue* changed_properties = new base::DictionaryValue();
+ scoped_ptr<base::DictionaryValue> changed_properties(
+ new base::DictionaryValue());
changed_properties->SetString(tabs_constants::kStatusKey,
tabs_constants::kStatusValueLoading);
- if (contents->GetURL() != url_) {
- url_ = contents->GetURL();
+ if (contents_->GetURL() != url_) {
+ url_ = contents_->GetURL();
changed_properties->SetString(tabs_constants::kUrlKey, url_.spec());
}
- return changed_properties;
+ return changed_properties.Pass();
+}
+
+bool TabsEventRouter::TabEntry::SetAudible(bool new_val) {
+ if (was_audible_ == new_val)
+ return false;
+ was_audible_ = new_val;
+ return true;
+}
+
+bool TabsEventRouter::TabEntry::SetMuted(bool new_val) {
+ if (was_muted_ == new_val)
+ return false;
+ was_muted_ = new_val;
+ return true;
}
TabsEventRouter::TabsEventRouter(Profile* profile)
@@ -112,7 +133,7 @@ TabsEventRouter::TabsEventRouter(Profile* profile)
for (int i = 0; i < browser->tab_strip_model()->count(); ++i) {
WebContents* contents = browser->tab_strip_model()->GetWebContentsAt(i);
int tab_id = ExtensionTabUtil::GetTabId(contents);
- tab_entries_[tab_id] = TabEntry();
+ tab_entries_[tab_id] = make_linked_ptr(new TabEntry(contents));
}
}
}
@@ -217,8 +238,8 @@ void TabsEventRouter::TabInsertedAt(WebContents* contents,
bool active) {
// If tab is new, send created event.
int tab_id = ExtensionTabUtil::GetTabId(contents);
- if (!GetTabEntry(contents)) {
- tab_entries_[tab_id] = TabEntry();
+ if (GetTabEntry(contents).get() == NULL) {
+ tab_entries_[tab_id] = make_linked_ptr(new TabEntry(contents));
TabCreatedAt(contents, index, active);
return;
@@ -241,7 +262,7 @@ void TabsEventRouter::TabInsertedAt(WebContents* contents,
}
void TabsEventRouter::TabDetachedAt(WebContents* contents, int index) {
- if (!GetTabEntry(contents)) {
+ if (GetTabEntry(contents).get() == NULL) {
// The tab was removed. Don't send detach event.
return;
}
@@ -393,20 +414,30 @@ void TabsEventRouter::TabMoved(WebContents* contents,
EventRouter::USER_GESTURE_UNKNOWN);
}
-void TabsEventRouter::TabUpdated(WebContents* contents, bool did_navigate) {
- TabEntry* entry = GetTabEntry(contents);
- scoped_ptr<base::DictionaryValue> changed_properties;
+void TabsEventRouter::TabUpdated(
+ linked_ptr<TabEntry> entry,
+ scoped_ptr<base::DictionaryValue> changed_properties) {
+ CHECK(entry->web_contents());
- if (!entry)
- return;
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableTabAudioMuting)) {
+ bool audible = entry->web_contents()->WasRecentlyAudible();
+ if (entry->SetAudible(audible)) {
+ changed_properties->SetBoolean(tabs_constants::kAudibleKey, audible);
+ }
- if (did_navigate)
- changed_properties.reset(entry->DidNavigate(contents));
- else
- changed_properties.reset(entry->UpdateLoadState(contents));
+ bool muted = entry->web_contents()->IsAudioMuted();
+ if (entry->SetMuted(muted)) {
+ changed_properties->SetBoolean(tabs_constants::kMutedKey, muted);
+ changed_properties->SetString(
+ tabs_constants::kMutedCauseKey,
+ chrome::GetTabAudioMutedCause(entry->web_contents()));
+ }
+ }
- if (changed_properties)
- DispatchTabUpdatedEvent(contents, changed_properties.Pass());
+ if (!changed_properties->empty()) {
+ DispatchTabUpdatedEvent(entry->web_contents(), changed_properties.Pass());
+ }
}
void TabsEventRouter::FaviconUrlUpdated(WebContents* contents) {
@@ -483,12 +514,14 @@ void TabsEventRouter::DispatchTabUpdatedEvent(
EventRouter::Get(profile)->BroadcastEvent(event.Pass());
}
-TabsEventRouter::TabEntry* TabsEventRouter::GetTabEntry(WebContents* contents) {
+linked_ptr<TabsEventRouter::TabEntry> TabsEventRouter::GetTabEntry(
+ WebContents* contents) {
int tab_id = ExtensionTabUtil::GetTabId(contents);
- std::map<int, TabEntry>::iterator i = tab_entries_.find(tab_id);
+
+ TabEntryMap::iterator i = tab_entries_.find(tab_id);
if (tab_entries_.end() == i)
- return NULL;
- return &i->second;
+ return linked_ptr<TabEntry>(NULL);
+ return i->second;
}
void TabsEventRouter::Observe(int type,
@@ -497,7 +530,10 @@ void TabsEventRouter::Observe(int type,
if (type == content::NOTIFICATION_NAV_ENTRY_COMMITTED) {
NavigationController* source_controller =
content::Source<NavigationController>(source).ptr();
- TabUpdated(source_controller->GetWebContents(), true);
+ linked_ptr<TabEntry> entry =
+ GetTabEntry(source_controller->GetWebContents());
+ CHECK(entry.get());
+ TabUpdated(entry, (entry.get())->DidNavigate());
} else if (type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED) {
// Tab was destroyed after being detached (without being re-attached).
WebContents* contents = content::Source<WebContents>(source).ptr();
@@ -515,7 +551,9 @@ void TabsEventRouter::Observe(int type,
void TabsEventRouter::TabChangedAt(WebContents* contents,
int index,
TabChangeType change_type) {
- TabUpdated(contents, false);
+ linked_ptr<TabEntry> entry = GetTabEntry(contents);
+ CHECK(entry.get());
+ TabUpdated(entry, (entry.get())->UpdateLoadState());
}
void TabsEventRouter::TabReplacedAt(TabStripModel* tab_strip_model,
@@ -540,8 +578,8 @@ void TabsEventRouter::TabReplacedAt(TabStripModel* tab_strip_model,
DCHECK_GT(removed_count, 0);
UnregisterForTabNotifications(old_contents);
- if (!GetTabEntry(new_contents)) {
- tab_entries_[new_tab_id] = TabEntry();
+ if (GetTabEntry(new_contents).get() == NULL) {
+ tab_entries_[new_tab_id] = make_linked_ptr(new TabEntry(new_contents));
RegisterForTabNotifications(new_contents);
}
}
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_event_router.h ('k') | chrome/browser/extensions/extension_tab_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698