Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 987583004: Add audible, muted to Tab, c.t.query, c.t.update, and c.t.onUpdated where relevant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch1
Patch Set: Make TabsEventRouter a friend to TabEntry so that it will build on some platforms Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_apitest.cc
diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc
index 36003da5bcc7ae582ffd26920f7be6f956115d62..c3ada31d6d0ab733c26e59140ab21d4b44176c0e 100644
--- a/chrome/browser/extensions/extension_tabs_apitest.cc
+++ b/chrome/browser/extensions/extension_tabs_apitest.cc
@@ -47,6 +47,16 @@ class ExtensionApiNewTabTest : public ExtensionApiTest {
}
};
+class ExtensionApiTabAudioMutingTest : public ExtensionApiTest {
+ public:
+ ExtensionApiTabAudioMutingTest() {}
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ ExtensionApiTest::SetUpCommandLine(command_line);
+
+ command_line->AppendSwitch(switches::kEnableTabAudioMuting);
+ }
+};
+
IN_PROC_BROWSER_TEST_F(ExtensionApiNewTabTest, Tabs) {
// The test creates a tab and checks that the URL of the new tab
// is that of the new tab page. Make sure the pref that controls
@@ -57,6 +67,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiNewTabTest, Tabs) {
ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud.html")) << message_;
}
+IN_PROC_BROWSER_TEST_F(ExtensionApiTabAudioMutingTest, TabAudible) {
+ ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "audible.html")) << message_;
+}
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTabAudioMutingTest, TabMuted) {
+ ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "muted.html")) << message_;
+}
+
// Flaky on windows: http://crbug.com/238667
#if defined(OS_WIN)
#define MAYBE_Tabs2 DISABLED_Tabs2

Powered by Google App Engine
This is Rietveld 408576698