Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3364)

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 987583004: Add audible, muted to Tab, c.t.query, c.t.update, and c.t.onUpdated where relevant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch1
Patch Set: attempt to add kalman as reviewer via git-cl owners (didn't work) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/tabs.json
diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json
index 4fe70c74c900b9419ff51b5ae9e51131c1d1bc0e..c34a2f7e58273538b8990bad5710a1b0fca90081 100644
--- a/chrome/common/extensions/api/tabs.json
+++ b/chrome/common/extensions/api/tabs.json
@@ -20,6 +20,8 @@
"highlighted": {"type": "boolean", "description": "Whether the tab is highlighted."},
"active": {"type": "boolean", "description": "Whether the tab is active in its window. (Does not necessarily mean the window is focused.)"},
"pinned": {"type": "boolean", "description": "Whether the tab is pinned."},
+ "audible": {"type": "boolean", "optional": true, "description": "Whether the tab is audible."},
not at google - send to devlin 2015/03/10 22:30:08 Explain the difference between audible and muted,
Jared Sohn 2015/03/16 02:34:29 Here is my new verbiage (feel free to give feedbac
not at google - send to devlin 2015/03/16 17:47:08 Perfect.
+ "muted": {"type": "boolean", "optional": true, "description": "Whether the tab is muted."},
"url": {"type": "string", "optional": true, "description": "The URL the tab is displaying. This property is only present if the extension's manifest includes the <code>\"tabs\"</code> permission."},
"title": {"type": "string", "optional": true, "optional": true, "description": "The title of the tab. This property is only present if the extension's manifest includes the <code>\"tabs\"</code> permission."},
"favIconUrl": {"type": "string", "optional": true, "optional": true, "description": "The URL of the tab's favicon. This property is only present if the extension's manifest includes the <code>\"tabs\"</code> permission. It may also be an empty string if the tab is loading."},
@@ -366,6 +368,16 @@
"optional": true,
"description": "Whether the tabs are pinned."
},
+ "audible": {
+ "type": "boolean",
+ "optional": true,
+ "description": "Whether the tabs are audible."
+ },
+ "muted": {
+ "type": "boolean",
+ "optional": true,
+ "description": "Whether the tabs are muted."
+ },
"highlighted": {
"type": "boolean",
"optional": true,
@@ -514,6 +526,11 @@
"optional": true,
"description": "Whether the tab should be pinned."
},
+ "muted": {
+ "type": "boolean",
+ "optional": true,
+ "description": "Whether the tab should be muted."
+ },
"openerTabId": {
"type": "integer",
"minimum": 0,
@@ -861,6 +878,21 @@
"optional": true,
"description": "The tab's new pinned state."
},
+ "audible": {
+ "type": "boolean",
+ "optional": true,
+ "description": "The tab's new audible state."
+ },
+ "muted": {
+ "type": "boolean",
+ "optional": true,
+ "description": "The tab's new muted state."
+ },
+ "cause": {
not at google - send to devlin 2015/03/10 22:30:08 I'd rather "mutedCause" because this is muted spec
Jared Sohn 2015/03/16 02:34:29 I had been debating that; "cause" could be reused
+ "type": "string",
+ "optional": true,
+ "description": "When the muted state changes, indicates what caused it ('user', 'capture', or an extension id)."
+ },
"favIconUrl": {
"type": "string",
"optional": true,

Powered by Google App Engine
This is Rietveld 408576698