Add audible, muted to Tab, c.t.query, c.t.update, and c.t.onUpdated where relevant

chrome/test/data/extensions/api_test/tabs/basics/tabs_util.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var pass = chrome.test.callbackPass;
 var fail = chrome.test.callbackFail;
 var assertEq = chrome.test.assertEq;
 var assertFalse = chrome.test.assertFalse;
 var assertTrue = chrome.test.assertTrue;
 
@@ skipping 17 matching lines @@
     callback(win.id, newTabIds);
   });
 }
 
 // Waits until all tabs (yes, in every window) have status "complete".
 // This is useful to prevent test overlap when testing tab events.
 // |callback| should look like function() {...}.  Note that |callback| expects
 // zero arguments.
 function waitForAllTabs(callback) {
   // Wait for all tabs to load.
-  function waitForTabs(){
+  function waitForTabs() {
     chrome.windows.getAll({"populate": true}, function(windows) {
       var ready = true;
-      for (var i in windows){
+      for (var i in windows) {
         for (var j in windows[i].tabs) {
           if (windows[i].tabs[j].status != "complete") {
             ready = false;
             break;
           }
         }
         if (!ready)
           break;
       }
       if (ready)
         callback();
       else
         window.setTimeout(waitForTabs, 30);
     });
   }
   waitForTabs();
 }
+
+// Do a c.t.query and return the found tab (or undefined) in a callback

[not at google - send to devlin, 2015/06/01 20:33:57]

Huh, funny, I guess we should support a tabId property in query. A little bit
silly needing to write code like this - but I guess it's for a test, so makes
sense.

Btw I'd find the comment "Like chrome.tabs.query, but with the ability to filter
by |tabId| as well. Returns the found tab, or null" more useful.

[Jared Sohn, 2015/06/02 08:54:38]

Yeah, I like that better; updated.

On 2015/06/01 at 20:33:57, kalman wrote:

+function queryForTab(tabId, queryInfo, callback) {
+  chrome.tabs.query(queryInfo,
+    pass(function(tabs) {
+      var foundTabs = tabs.filter(function(tab) {
+        return (tab.id == tabId);
+      });
+      if (callback !== null)
+        callback(foundTabs.length ? foundTabs[0] : undefined);

[not at google - send to devlin, 2015/06/01 20:33:57]

epic nit but this isn't "undefined", because we know what it is - it's nothing
(in fact, no object). Therefore it should be "null". Kind of like how
document.getElementById() returns "null" if it's not found.

[Jared Sohn, 2015/06/02 08:54:38]

Done. (A previous iteration of the code would pass the query value into the
callback and would set it to undefined if the tab didn't exist.)

+    })
+  );
+}
+
+// Check onUpdated for a queryable attribute such as muted or audible
+// and then check that the tab, a query, and changeInfo are consistent
+// with the expected value.  Does similar checks for each
+// (nonqueryable attribute, expected value) pair in nonqueryableAttribsDict
+// except it does not check the query.
+function onUpdatedExpect(queryableAttrib, expected, nonqueryableAttribsDict) {
+  var onUpdatedCompleted = chrome.test.listenForever(
+    chrome.tabs.onUpdated,
+    function(tabId, changeInfo, tab) {
+      if (nonqueryableAttribsDict !== null) {
+        var nonqueryableAttribs = Object.keys(nonqueryableAttribsDict);
+        nonqueryableAttribs.forEach(function(nonqueryableAttrib) {
+          if (typeof changeInfo[nonqueryableAttrib] !== "undefined") {
+            assertEq(nonqueryableAttribsDict[nonqueryableAttrib],
+                     changeInfo[nonqueryableAttrib]);
+            assertEq(nonqueryableAttribsDict[nonqueryableAttrib],
+                     tab[nonqueryableAttrib]);
+          }
+        });
+      }
+      if (queryableAttrib in changeInfo) {

[not at google - send to devlin, 2015/06/01 20:33:57]

use hasOwnProperty, otherwise it will include properties on Object (i.e. look up
prototype chain).

[Jared Sohn, 2015/06/02 08:54:38]

Done.

+        assertEq(expected, changeInfo[queryableAttrib]);
+        assertEq(expected, tab[queryableAttrib]);
+        var queryInfo = {};
+        queryInfo[queryableAttrib] = expected;
+        queryForTab(tabId, queryInfo, pass(function(tab) {
+          assertEq(expected, tab[queryableAttrib]);
+          queryInfo[queryableAttrib] = !expected;
+
+          queryForTab(tabId, queryInfo, pass(function(tab) {
+            assertEq(undefined, tab);
+            onUpdatedCompleted();
+          }));
+        }));
+      }
+    }
+  );
+}