Add audible, muted to Tab, c.t.query, c.t.update, and c.t.onUpdated where relevant

chrome/test/data/extensions/api_test/tabs/basics/audible.js

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[not at google - send to devlin, 2015/05/26 23:09:48]

2015

[Jared Sohn, 2015/05/27 14:52:02]

Done (also changed muted.js, sinewave.js, and disable_sinewave.js; the code for
the latter two came from
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/e...)
but I am assuming the copyright should be for the year that the file was
created.)

[not at google - send to devlin, 2015/05/28 23:04:42]

Correct.

[not at google - send to devlin, 2015/06/01 20:33:56]

btw we also now leave the (c) out, for the record.

[Jared Sohn, 2015/06/02 08:54:38]

Updated in new files.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var testTabId_;
+
+function injectScriptIntoOnlyTab(filename)
+{

[not at google - send to devlin, 2015/05/26 23:09:48]

Open brace should be on same line as function name declaration.

[Jared Sohn, 2015/05/27 14:52:02]

Done.

+  var views = chrome.extension.getViews({type: "tab"});
+  assertEq(1, views.length);
+  var scriptElem = views[0].document.createElement("script");
+  scriptElem.type = "text/javascript";
+  scriptElem.src = filename;
+  views[0].document.body.appendChild(scriptElem);

[not at google - send to devlin, 2015/05/26 23:09:48]

Instead of this you should be able to do something like
"views[0].contentWindow.disableSinewave()" or whatever - if you define the
disableSinewave function inside the tab that you're loading, whatever that is.

And in that case, I'd compose this with a function "getOnlyTab" then call below
with getOnlyTab.disableSinewave() and getOnlyTab.enableSinewave().

[Jared Sohn, 2015/05/27 14:52:02]

Would doing this match your suggestion? 
-- create an .HTML file that gets loaded for this test (instead of the generic
one used for other tests)
-- file should include sinewave.js and expose enableSinewave and disableSinewave
functions
-- remove the disable_sinewave.js file

[not at google - send to devlin, 2015/05/28 23:04:42]

Sounds good to me.

+}
+
+chrome.test.runTests([
+  function setupWindow() {
+    chrome.tabs.getCurrent(pass(function(tab) {
+      testTabId_ = tab.id;

[miu, 2015/05/26 21:28:47]

kalman@'s more familiar with the JS extension testing than I am.  But, IIRC, you
should be calling chrome.test.succeed() for each function passed to
chrome.test.runTests().

[not at google - send to devlin, 2015/05/26 23:09:47]

Very confusingly, callbackPass (which pass is aliased to) calls succeed()
itself:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/rendere...

[Jared Sohn, 2015/05/27 14:52:02]

Correct. I am using pass here to be consistent with other tabs tests and am
using chrome.test.succeed within the tabcapture test to be consistent with those
tests.

+    }));
+  },
+
+  function audibleStartsFalse() {
+    chrome.tabs.get(testTabId_, pass(function(tab) {
+      assertEq(false, tab.audible);
+      checkQuery(testTabId_, "audible", false, true, null);
+      checkQuery(testTabId_, "audible", true, false, null);
+    }));
+  },
+
+  function audibleUpdateAttempt() {

[miu, 2015/05/26 21:28:46]

naming nit: How about audibleUpdateAttemptShouldFail()?

[Jared Sohn, 2015/05/27 14:52:02]

Done.

+    var error_msg = "Invalid value for argument 2. Property 'audible': " +
+      "Unexpected property.";
+
+    try
+    {
+      chrome.tabs.update(testTabId_, {audible: true}, function(tab) {
+        chrome.test.fail("Updated audible property via chrome.tabs.update");
+      });
+    } catch (e)
+    {
+      assertEq(error_msg, e.message);
+      chrome.test.succeed();
+    }
+  },
+
+  function makeAudible() {
+    onUpdatedExpect("audible", true, null);
+    injectScriptIntoOnlyTab("sinewave.js");
+  },
+
+  function testStaysAudibleAfterChangingWindow() {

[miu, 2015/05/26 21:28:46]

Not sure if it's necessary to test the state after a tab is moved between
windows, but I'm not against keeping this in the tests either.

[Jared Sohn, 2015/05/27 14:52:02]

The intention behind this test is because this patch (minimally) touches code in
TabsEventRouter::TabInsertedAt and this test gives some assurance that it wasn't
broken.

[miu, 2015/05/27 20:10:14]

Okay.  Sounds good to me.  :)

+    chrome.windows.create({}, pass(function(window)
+    {
+      chrome.tabs.move(testTabId_, {windowId: window.id, index: -1},
+                       pass(function(tab) {
+        assertEq(true, tab.audible);
+      }));
+    }));
+  },
+
+  function makeNotAudible() {
+    onUpdatedExpect("audible", false, null);
+    injectScriptIntoOnlyTab("disable_sinewave.js");
+  }
+]);