Add audible, muted to Tab, c.t.query, c.t.update, and c.t.onUpdated where relevant

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 25 matching lines @@
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/tabs/tab_utils.h"
 #include "chrome/browser/ui/window_sizer/window_sizer.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/api/tabs.h"
 #include "chrome/common/extensions/api/windows.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/translate/core/browser/language_state.h"
@@ skipping 845 matching lines @@
       if (!MatchesBool(params->query_info.active.get(),
                        i == tab_strip->active_index())) {
         continue;
       }
 
       if (!MatchesBool(params->query_info.pinned.get(),
                        tab_strip->IsTabPinned(i))) {
         continue;
       }
 
+      if (!MatchesBool(params->query_info.audible.get(),
+                       chrome::IsPlayingAudio(web_contents))) {
+        continue;
+      }
+
+      if (!MatchesBool(params->query_info.muted.get(),
+                       chrome::IsTabAudioMuted(web_contents))) {
+        continue;
+      }
+
       if (!title.empty() && !MatchPattern(web_contents->GetTitle(),
                                           base::UTF8ToUTF16(title)))
         continue;
 
       if (!url_patterns.is_empty() &&
           !url_patterns.MatchesURL(web_contents->GetURL()))
         continue;
 
       if (loading_status_set && loading != web_contents->IsLoading())
         continue;
@@ skipping 257 matching lines @@
   }
 
   if (params->update_properties.pinned.get()) {
     bool pinned = *params->update_properties.pinned;
     tab_strip->SetTabPinned(tab_index, pinned);
 
     // Update the tab index because it may move when being pinned.
     tab_index = tab_strip->GetIndexOfWebContents(contents);
   }
 
+  if (params->update_properties.muted.get()) {
+    bool muted = *params->update_properties.muted;

[not at google - send to devlin, 2015/05/26 23:09:46]

Could you make this (and I may have the names wrong here, and git cl format may
choose to change it):

const char* switch = base::Comment::switches::kEnableTabAudioMuting;
if (base::CommandLine::HasSwitch(switch)) {
  chrome::SetTabAudioMuted(contents, *params->update_properties.muted,
                           extension()->id());
} else {
  WriteToConsole(
      WARNING,
      base::StringPrintf("Failed to update mute state, --%s must be enabled",
                         switch));
}

[Jared Sohn, 2015/05/27 14:52:02]

Done (after making a few changes including not naming the variable 'switch' ;)).

It looks like the motivation here is to turn off muting if the flag isn't set. 
Should there also be a flag for turning on/off the API changes?  (The creating
new APIs website
(http://www.chromium.org/developers/design-documents/extensions/proposed-chang...)
indicates such but here we are modifying an existing API instead of creating a
new one.  It seems straightforward to remove the new fields from the tab object
and to disable c.t.update (like we do here), but it isn't clear to me how to
remove them from c.t.onUpdated and c.t.query.)

[not at google - send to devlin, 2015/05/28 23:04:42]

Nah no need for a separate flag. I think the API can just be written once and
when tab muting is enabled, the API can start working.

An interesting question is actually whether using the API should automatically
enable tab muting; in other words, is the flag designed for the ability of tab
muting, or is it for the UI? If just the latter, we should give the API free
reign. mui?

[miu, 2015/05/28 23:36:59]

It's designed to report whatever state the WebContents is in, whether muting is
being controlled from the UI or an extension via this new API.  I think the
simple answer is, yes, the API should get free reign.  We're still discussing
(behind-the-scenes) whether muting will become a permanent member of the tab
strip UI.  ;-)

[not at google - send to devlin, 2015/05/29 21:28:15]

Awesome. In that case we should actually be able to remove the command line
checks from everywhere?

+    chrome::SetTabAudioMuted(contents, muted, extension()->id());
+  }
+
   if (params->update_properties.opener_tab_id.get()) {
     int opener_id = *params->update_properties.opener_tab_id;
 
     WebContents* opener_contents = NULL;
     if (!ExtensionTabUtil::GetTabById(opener_id,
                                       GetProfile(),
                                       include_incognito(),
                                       NULL,
                                       NULL,
                                       &opener_contents,
@@ skipping 753 matching lines @@
   ZoomController::ZoomMode zoom_mode = zoom_controller->zoom_mode();
   api::tabs::ZoomSettings zoom_settings;
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions