build/config/features.gni - Issue 987553002: Audit GN cflags and defines to match GYP build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/features.gni

Issue 987553002: Audit GN cflags and defines to match GYP build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/win/BUILD.gn » ('j') | skia/BUILD.gn » ('J')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This file contains UI-related build flags. It should theoretically be in the	5 # This file contains UI-related build flags. It should theoretically be in the

6 # src/ui directory and only things that depend on the ui module should get the	6 # src/ui directory and only things that depend on the ui module should get the

7 # definitions.	7 # definitions.

8 #	8 #

9 # However, today we have many "bad" dependencies on some of these flags from,	9 # However, today we have many "bad" dependencies on some of these flags from,

10 # e.g. base, so they need to be global.	10 # e.g. base, so they need to be global.

(...skipping 160 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
171	171

172 # Option controlling the use of GConf (the classic GNOME configuration	172 # Option controlling the use of GConf (the classic GNOME configuration

173 # system).	173 # system).

174 # TODO(GYP) also require !embedded to enable.	174 # TODO(GYP) also require !embedded to enable.

175 use_gconf = is_linux && !is_chromeos	175 use_gconf = is_linux && !is_chromeos

176	176

177 # Hangout services is an extension that adds extra features to Hangouts.	177 # Hangout services is an extension that adds extra features to Hangouts.

178 # For official GYP builds, this flag is set, it will likely need to be	178 # For official GYP builds, this flag is set, it will likely need to be

179 # parameterized in the future for a similar use.	179 # parameterized in the future for a similar use.

180 enable_hangout_services_extension = false	180 enable_hangout_services_extension = false

	181

	182 # Whether to back up data before sync.

	183 enable_pre_sync_backup = is_win \|\| is_mac \|\| (is_linux && !is_chromeos)

OLD	NEW