Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 987553002: Audit GN cflags and defines to match GYP build. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit GN cflags and defines to match GYP build. This makes Skia compile on Windows in component build. Committed: https://crrev.com/c30f70d94e8a470b57009fbfb14b7c6bd0783cc7 Cr-Commit-Position: refs/heads/master@{#319357}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -29 lines) Patch
M build/config/BUILD.gn View 1 2 chunks +16 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 3 chunks +1 line, -9 lines 0 comments Download
M build/config/features.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/BUILD.gn View 1 4 chunks +11 lines, -10 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
brettw
https://codereview.chromium.org/987553002/diff/20001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/987553002/diff/20001/skia/BUILD.gn#newcode266 skia/BUILD.gn:266: gn format did this.
5 years, 9 months ago (2015-03-05 21:56:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987553002/20001
5 years, 9 months ago (2015-03-05 22:27:48 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-05 22:27:49 UTC) #6
jam
lgtm
5 years, 9 months ago (2015-03-05 22:28:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987553002/20001
5 years, 9 months ago (2015-03-05 22:30:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 23:14:01 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 23:14:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c30f70d94e8a470b57009fbfb14b7c6bd0783cc7
Cr-Commit-Position: refs/heads/master@{#319357}

Powered by Google App Engine
This is Rietveld 408576698