tools/dm_flags.py - Issue 987533002: Disable --config pdf temporarily on Valgrind bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dm_flags.py

Issue 987533002: Disable --config pdf temporarily on Valgrind bot. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dm_flags.py

diff --git a/tools/dm_flags.py b/tools/dm_flags.py

index 548bb3515f127561c1e520949d6988788a03c014..583d4f2b479f96508d459b7fb63a5104194245e7 100755

--- a/tools/dm_flags.py

+++ b/tools/dm_flags.py

@@ -32,7 +32,8 @@ def get_args(bot):

else:

configs.extend(['msaa16', 'nvprmsaa16'])

# Runs out of memory on Android bots and Daisy. Everyone else seems fine.

- if 'Android' not in bot and 'Daisy' not in bot:

+ # Valgrind: PDF + .webp -> jumps depending on uninitialized memory. skia:3505

+ if 'Android' not in bot and 'Daisy' not in bot and 'Valgrind' not in bot:

configs.append('pdf')

# Xoom and NP are running out of RAM when we run all these modes. skia:3255

« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »