components/autofill/content/browser/request_autocomplete_manager.cc - Issue 98753005: [Autofill] Sanitize all data that comes in over IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/request_autocomplete_manager.cc

Issue 98753005: [Autofill] Sanitize all data that comes in over IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Loosen kMaxListSize a notch Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/autofill_driver_impl.cc ('k') | components/autofill/content/common/autofill_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/request_autocomplete_manager.cc

diff --git a/components/autofill/content/browser/request_autocomplete_manager.cc b/components/autofill/content/browser/request_autocomplete_manager.cc

index f48610f91d77fe1a8e835c7261a2e2ade608fa9c..79b012188fd63f9a6ab86fd1e61cc12d06416176 100644

--- a/components/autofill/content/browser/request_autocomplete_manager.cc

+++ b/components/autofill/content/browser/request_autocomplete_manager.cc

@@ -7,6 +7,7 @@

#include "components/autofill/content/browser/autofill_driver_impl.h"

#include "components/autofill/content/common/autofill_messages.h"

#include "components/autofill/core/browser/form_structure.h"

+#include "components/autofill/core/common/autofill_data_validation.h"

#include "components/autofill/core/common/form_data.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

@@ -26,6 +27,9 @@ RequestAutocompleteManager::~RequestAutocompleteManager() {}

void RequestAutocompleteManager::OnRequestAutocomplete(

const FormData& form,

const GURL& frame_url) {

+ if (!IsValidFormData(form))

+ return;

if (!autofill_driver_->autofill_manager()->IsAutofillEnabled()) {

ReturnAutocompleteResult(

blink::WebFormElement::AutocompleteResultErrorDisabled,