Issue 987523002: Dart: Fixes bug in MojoEventStreamListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987523002: Dart: Fixes bug in MojoEventStreamListener (Closed)

Created:
5 years, 9 months ago by zra

Modified:
5 years, 9 months ago

Reviewers:
Elliot Glaysher

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Dart: Fixes bug in MojoEventStreamListener This is the real cause of the hangs in Dart apptests. BUG= R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/53b91654aaf55094714efcfae471ee123610c75e

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -22 lines)			Patch
M	mojo/public/dart/src/event_stream.dart	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	services/dart/dart_apptests/echo_apptests.dart	View	4 chunks	+12 lines, -6 lines	0 comments	Download
M	services/dart/dart_apptests/pingpong_apptests.dart	View	5 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

Sorry for the churn. It turns out that the unittest package already does the right ...

5 years, 9 months ago (2015-03-05 20:40:32 UTC) #2

Elliot Glaysher

lgtm (I'm just glad that we don't have to do that then() cruft.)

5 years, 9 months ago (2015-03-05 20:42:42 UTC) #3

zra

5 years, 9 months ago (2015-03-05 20:52:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
53b91654aaf55094714efcfae471ee123610c75e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages