Subzero: Run cross tests as a much more configurable python script.

pydir/crosstest.py

 #!/usr/bin/env python2
 
 import argparse
 import os
 import subprocess
 import sys
 import tempfile
 
 from utils import shellcmd
 from utils import FindBaseNaCl
 
 def main():
     """Builds a cross-test binary that allows functions translated by
     Subzero and llc to be compared.
 
     Each --test argument is compiled once by llc and once by Subzero.
     C/C++ tests are first compiled down to PNaCl bitcode by the
     build-pnacl-ir.py script.  The --prefix argument ensures that

[jvoung (off chromium), 2015/03/09 17:34:21]

see question about build-pnacl-ir

[Jim Stichnoth, 2015/03/09 18:16:16]

Ah, nice catch, updated the documentation.

     symbol names are different between the two object files, to avoid
     linking errors.
 
     There is also a --driver argument that specifies the C/C++ file
     that calls the test functions with a variety of interesting inputs
     and compares their results.
     """
     # arch_map maps a Subzero target string to an llvm-mc -triple string.
     arch_map = { 'x8632':'i686', 'x8664':'x86_64', 'arm':'armv7a' }
     desc = 'Build a cross-test that compares Subzero and llc translation.'
@@ skipping 40 matching lines @@
                            ' Default %(default)d.')
     argparser.add_argument('--filetype', default='obj', dest='filetype',
                            choices=['obj', 'asm', 'iasm'],
                            help='Output file type.  Default %(default)s.')
     args = argparser.parse_args()
 
     nacl_root = FindBaseNaCl()
     bindir = ('{root}/toolchain/linux_x86/pnacl_newlib/bin'
               .format(root=nacl_root))
     triple = arch_map[args.target] + ('-nacl' if args.sandbox else '')
+    mypath = os.path.abspath(os.path.dirname(sys.argv[0]))
 
     objs = []
     for arg in args.test:
+        # Construct a "unique key" for each test so that tests can be run in
+        # parallel without race conditions on temporary file creation.
+        key = '{target}.{sb}.O{opt}.{attr}'.format(
+            target=args.target, sb='sb' if args.sandbox else 'nat',
+            opt=args.optlevel, attr=args.attr)
         base, ext = os.path.splitext(arg)
         if ext == '.ll':
             bitcode = arg
         else:
-            bitcode = os.path.join(args.dir, base + '.pnacl.ll')
-            shellcmd(['../pydir/build-pnacl-ir.py', '--disable-verify',

[jvoung (off chromium), 2015/03/09 17:34:21]

Is build-pnacl-ir still useful after this change?

[Jim Stichnoth, 2015/03/09 18:16:16]

It isn't used by our scripts, but it's still kind of useful for
hand-constructing a lit test or a .ll cross test starting from C/C++ source. 
What do you think?

[jvoung (off chromium), 2015/03/09 20:34:59]

Hmm, up to you. I guess it could be a useful shortcut for that. I hadn't thought
to use it that way to start a .ll file.

[Jim Stichnoth, 2015/03/09 20:37:48]

Heh, that's where all those .pnacl.ll lit tests (and one cross test) came from.
:)

-                      '--dir', args.dir, arg])
+            # Use pnacl-clang and pnacl-opt to produce PNaCl bitcode.
+            bitcode_nonfinal = os.path.join(args.dir, base + '.' + key + '.bc')
+            bitcode = os.path.join(args.dir, base + '.' + key + '.pnacl.ll')
+            shellcmd(['{bin}/pnacl-clang'.format(bin=bindir),
+                      '-O2', '-c', arg, '-o', bitcode_nonfinal])
+            shellcmd(['{bin}/pnacl-opt'.format(bin=bindir),
+                      '-pnacl-abi-simplify-preopt',
+                      '-pnacl-abi-simplify-postopt',
+                      '-pnaclabi-allow-debug-metadata',
+                      bitcode_nonfinal, '-S', '-o', bitcode])
 
-        base_sz = '{base}.{sb}.O{opt}.{attr}.{target}'.format(
-            base=base, sb='sb' if args.sandbox else 'nat', opt=args.optlevel,
-            attr=args.attr, target=args.target)
+        base_sz = '{base}.{key}'.format(base=base, key=key)
         asm_sz = os.path.join(args.dir, base_sz + '.sz.s')
         obj_sz = os.path.join(args.dir, base_sz + '.sz.o')
         obj_llc = os.path.join(args.dir, base_sz + '.llc.o')
-        shellcmd(['../pnacl-sz',
+        shellcmd(['{path}/pnacl-sz'.format(path=os.path.dirname(mypath)),
                   '-O' + args.optlevel,
                   '-mattr=' + args.attr,
                   '--target=' + args.target,
                   '--sandbox=' + str(args.sandbox),
                   '--prefix=' + args.prefix,
                   '-allow-uninitialized-globals',
                   '-externalize',
                   '-filetype=' + args.filetype,
                   '-o=' + (obj_sz if args.filetype == 'obj' else asm_sz),
                   bitcode])
@@ skipping 30 matching lines @@
         bin=bindir, prefix='pnacl-' if args.sandbox else '',
         cc='clang' if pure_c else 'clang++')
     sb_native_args = (['-O0', '--pnacl-allow-native', '-arch', 'x8632']
                       if args.sandbox else
                       ['-g', '-m32', '-lm', '-lpthread'])
     shellcmd([compiler, args.driver] + objs +
              ['-o', os.path.join(args.dir, args.output)] + sb_native_args)
 
 if __name__ == '__main__':
     main()