Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 987503002: Autofill OSX: Replace AutofillPopUpButton with NSPopUpButton. (Closed)

Created:
5 years, 9 months ago by bondd
Modified:
5 years, 9 months ago
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cup_03_add_contents_06
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill OSX: Replace AutofillPopUpButton with NSPopUpButton. There's no need for AutofillPopUpButton here. None of its functionality is used. BUG=448572 Committed: https://crrev.com/321edc106846b23420dcf0b5fa913ae2dc183706 Cr-Commit-Position: refs/heads/master@{#319676}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 3 chunks +5 lines, -8 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
bondd
https://codereview.chromium.org/987503002/diff/1/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm File chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm (left): https://codereview.chromium.org/987503002/diff/1/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm#oldcode98 chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm:98: model.GetItemAt(model.GetDefaultIndex()))]; defaultValue is not currently used so it's safe ...
5 years, 9 months ago (2015-03-05 23:51:06 UTC) #3
groby-ooo-7-16
lgtm
5 years, 9 months ago (2015-03-06 19:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987503002/1
5 years, 9 months ago (2015-03-09 17:12:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 17:47:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:49:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/321edc106846b23420dcf0b5fa913ae2dc183706
Cr-Commit-Position: refs/heads/master@{#319676}

Powered by Google App Engine
This is Rietveld 408576698