chrome/renderer/resources/extensions/extension_options_events.js - Issue 987473002: Added the onResize and onContentResize events to GuestViewEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/extension_options_events.js

Issue 987473002: Added the onResize and onContentResize events to GuestViewEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/extension_options_events.js

diff --git a/chrome/renderer/resources/extensions/extension_options_events.js b/chrome/renderer/resources/extensions/extension_options_events.js

index 0b5dd56ca42ae9f34460049f974737f6ef07c970..7ba2d05827d1dedd2c6226e30bc1b951fe1386fe 100644

--- a/chrome/renderer/resources/extensions/extension_options_events.js

+++ b/chrome/renderer/resources/extensions/extension_options_events.js

@@ -8,8 +8,8 @@ var GuestViewEvents = require('guestViewEvents').GuestViewEvents;

function ExtensionOptionsEvents(extensionOptionsImpl) {

GuestViewEvents.call(this, extensionOptionsImpl);

- // setupEventProperty is normally called automatically, but the 'createfailed'

- // event is registered here because the event is fired from

+ // |setupEventProperty| is normally called automatically, but the

+ // 'createfailed' event is registered here because the event is fired from

// ExtensionOptionsImpl instead of in response to an extension event.

this.setupEventProperty('createfailed');

}