Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: extensions/renderer/resources/guest_view/guest_view_events.js

Issue 987473002: Added the onResize and onContentResize events to GuestViewEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/guest_view/guest_view_container.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/guest_view_events.js
diff --git a/extensions/renderer/resources/guest_view/guest_view_events.js b/extensions/renderer/resources/guest_view/guest_view_events.js
index 415d0c4326df4ca4562839829a3244839d7b0f98..7559ee20b65c639838faa1197129b4d6fcf6f416 100644
--- a/extensions/renderer/resources/guest_view/guest_view_events.js
+++ b/extensions/renderer/resources/guest_view/guest_view_events.js
@@ -15,6 +15,11 @@ function GuestViewEvents(view) {
this.view = view;
this.on = {};
+ // |setupEventProperty| is normally called automatically, but these events are
+ // are registered here because they are dispatched from GuestViewContainer
+ // instead of in response to extension events.
+ this.setupEventProperty('contentResize');
Fady Samuel 2015/03/06 18:33:06 nit: all lowercase is expected for DOM events: con
paulmeyer 2015/03/06 18:37:09 Ah, right. Actually setupEventProperty() always co
+ this.setupEventProperty('resize');
this.setupEvents();
}
« no previous file with comments | « extensions/renderer/resources/guest_view/guest_view_container.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698