extensions/renderer/resources/guest_view/guest_view_container.js - Issue 987473002: Added the onResize and onContentResize events to GuestViewEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/guest_view_container.js

Issue 987473002: Added the onResize and onContentResize events to GuestViewEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/guest_view_base.cc ('K') | « extensions/renderer/resources/guest_view/guest_view.js ('k') | extensions/renderer/resources/guest_view/guest_view_events.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/guest_view_container.js

diff --git a/extensions/renderer/resources/guest_view/guest_view_container.js b/extensions/renderer/resources/guest_view/guest_view_container.js

index 95bb1deeaedf472f779f40aa8ccda3c838a79357..aec97c8c2126870aed5f444d7dea3fa85d8df7ad 100644

--- a/extensions/renderer/resources/guest_view/guest_view_container.js

+++ b/extensions/renderer/resources/guest_view/guest_view_container.js

@@ -114,10 +114,17 @@ GuestViewContainer.prototype.handleBrowserPluginAttributeMutation =

GuestViewContainer.prototype.onElementResize = function(oldWidth, oldHeight,

newWidth, newHeight) {

+ // Dispatch the 'resize' event.

+ var resizeEvent = new Event('resize', { bubbles: true });

+ resizeEvent.oldWidth = oldWidth;

+ resizeEvent.oldHeight = oldHeight;

+ resizeEvent.newWidth = newWidth;

+ resizeEvent.newHeight = newHeight;

+ this.dispatchEvent(resizeEvent);

if (!this.guest.getId())

return;

- this.guest.setSize(

- {normal: {width: newWidth, height: newHeight}});

+ this.guest.setSize({normal: {width: newWidth, height: newHeight}});

};

GuestViewContainer.prototype.buildParams = function() {