Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 987473002: Added the onResize and onContentResize events to GuestViewEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index 7e5568711db5d64b17226cc211db8ede3f94a465..9fbc20c71cc6e302256b71025087b39adf1b86e9 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -243,7 +243,10 @@ void GuestViewBase::DispatchOnResizeEvent(const gfx::Size& old_size,
args->SetInteger(guestview::kOldHeight, old_size.height());
args->SetInteger(guestview::kNewWidth, new_size.width());
args->SetInteger(guestview::kNewHeight, new_size.height());
+ scoped_ptr<base::DictionaryValue> args_copy(args.get()->DeepCopy());
DispatchEventToGuestProxy(new Event(guestview::kEventResize, args.Pass()));
+ DispatchEventToView(
+ new Event(guestview::kEventContentResize, args_copy.Pass()));
Fady Samuel 2015/03/05 20:24:55 I'm confused about this. Why are you dispatching t
paulmeyer 2015/03/05 20:30:36 One goes to the guest, and one to the container, s
paulmeyer 2015/03/06 18:31:02 After talking about this offline, I have removed t
}
void GuestViewBase::SetSize(const SetSizeParams& params) {

Powered by Google App Engine
This is Rietveld 408576698