Added the onResize and onContentResize events to GuestViewEvents.

Added the onResize and onContentResize events to GuestViewEvents.

Committed: https://crrev.com/4e0d1372aefe2ffd2d2be9ffc566f97a7a9d3848
Cr-Commit-Position: refs/heads/master@{#319513}

[paulmeyer, 2015-03-05 20:19:12]

Patchset #1 (id:1) has been deleted

[paulmeyer, 2015-03-05 20:19:42]

paulmeyer@chromium.org changed reviewers:
+ fsamuel@chromium.org

[paulmeyer, 2015-03-05 20:19:43]

+fsamuel@

[Fady Samuel, 2015-03-05 20:24:55]

https://codereview.chromium.org/987473002/diff/20001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/987473002/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:249: new
Event(guestview::kEventContentResize, args_copy.Pass()));
I'm confused about this. Why are you dispatching two events here?

[paulmeyer, 2015-03-05 20:30:36]

https://codereview.chromium.org/987473002/diff/20001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/987473002/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:249: new
Event(guestview::kEventContentResize, args_copy.Pass()));
On 2015/03/05 20:24:55, Fady Samuel wrote:
> I'm confused about this. Why are you dispatching two events here?

One goes to the guest, and one to the container, so that they both know about
the resize if there is a container. If not, the guest will still know and the
onresize property on the guest can still be used while it is detached.

[Fady Samuel, 2015-03-05 21:15:34]

https://codereview.chromium.org/987473002/diff/20001/chrome/browser/apps/gues...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/987473002/diff/20001/chrome/browser/apps/gues...
chrome/browser/apps/guest_view/web_view_browsertest.cc:2551: 
Remove these extra lines.

[paulmeyer, 2015-03-06 18:31:02]

ptal.

https://codereview.chromium.org/987473002/diff/20001/chrome/browser/apps/gues...
File chrome/browser/apps/guest_view/web_view_browsertest.cc (right):

https://codereview.chromium.org/987473002/diff/20001/chrome/browser/apps/gues...
chrome/browser/apps/guest_view/web_view_browsertest.cc:2551: 
On 2015/03/05 21:15:34, Fady Samuel wrote:
> Remove these extra lines.

Done.

https://codereview.chromium.org/987473002/diff/20001/extensions/browser/guest...
File extensions/browser/guest_view/guest_view_base.cc (right):

https://codereview.chromium.org/987473002/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/guest_view_base.cc:249: new
Event(guestview::kEventContentResize, args_copy.Pass()));
On 2015/03/05 20:30:36, Paul Meyer wrote:
> On 2015/03/05 20:24:55, Fady Samuel wrote:
> > I'm confused about this. Why are you dispatching two events here?
> 
> One goes to the guest, and one to the container, so that they both know about
> the resize if there is a container. If not, the guest will still know and the
> onresize property on the guest can still be used while it is detached.

After talking about this offline, I have removed the view event and will instead
have GuestViewContainer track the guest event by storing its GuestView in a
custom property and always listening for its resize.

[Fady Samuel, 2015-03-06 18:33:07]

https://codereview.chromium.org/987473002/diff/40001/extensions/renderer/reso...
File extensions/renderer/resources/guest_view/guest_view_events.js (right):

https://codereview.chromium.org/987473002/diff/40001/extensions/renderer/reso...
extensions/renderer/resources/guest_view/guest_view_events.js:21:
this.setupEventProperty('contentResize');
nit: all lowercase is expected for DOM events: contentresize.

[Fady Samuel, 2015-03-06 18:33:31]

lgtm + nit.

[paulmeyer, 2015-03-06 18:37:04]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2015-03-06 18:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/987473002/#ps60001 (title:
"Addressed nit.")

[paulmeyer, 2015-03-06 18:37:09]

https://codereview.chromium.org/987473002/diff/40001/extensions/renderer/reso...
File extensions/renderer/resources/guest_view/guest_view_events.js (right):

https://codereview.chromium.org/987473002/diff/40001/extensions/renderer/reso...
extensions/renderer/resources/guest_view/guest_view_events.js:21:
this.setupEventProperty('contentResize');
On 2015/03/06 18:33:06, Fady Samuel wrote:
> nit: all lowercase is expected for DOM events: contentresize.

Ah, right. Actually setupEventProperty() always converts the event name to all
lowercase anyways, but there's no reason not to be lowercase already here, so
I'll change it.

[commit-bot: I haz the power, 2015-03-06 18:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/987473002/60001

[paulmeyer, 2015-03-06 19:57:26]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2015-03-06 19:57:26]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/987473002/#ps80001 (title:
"Small fix.")

[commit-bot: I haz the power, 2015-03-06 20:31:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/987473002/80001

[commit-bot: I haz the power, 2015-03-06 21:46:24]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-03-06 21:47:51]

Patchset 4 (id:??) landed as
https://crrev.com/4e0d1372aefe2ffd2d2be9ffc566f97a7a9d3848
Cr-Commit-Position: refs/heads/master@{#319513}