Issue 987463002: Move fn.dart into /sky/framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987463002: Move fn.dart into /sky/framework (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Move fn.dart into /sky/framework It's awkward to work on fn.dart in the examples directory so this CL moves it to /sky/framework. Also, I've merged the whole library into one file instead of using the |part| mechanism. The whole thing isn't that big. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2bb2494edd84c5c98af9b8b527263ba53bd10eb3

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -737 lines)			Patch
D	sky/examples/fn/lib/component.dart	View	1 chunk	+0 lines, -164 lines	0 comments	Download
D	sky/examples/fn/lib/event.dart	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	sky/examples/fn/lib/fn.dart	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	sky/examples/fn/lib/node.dart	View	1 chunk	+0 lines, -435 lines	0 comments	Download
D	sky/examples/fn/lib/reflect.dart	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	sky/examples/fn/lib/style.dart	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	sky/examples/fn/widgets/item.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/fn/widgets/widgets.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/stocks-fn/stocksapp.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	sky/framework/fn.dart	View	2 chunks	+229 lines, -1 line	0 comments	Download
A +	sky/framework/reflect.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-05 18:53:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2bb2494edd84c5c98af9b8b527263ba53bd10eb3 (presubmit successful).