Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js

Issue 987433007: JS cleanup for cr_elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 * Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 * found in the LICENSE file. */ 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'cr-dropdown-menu' is a Chrome-specific wrapper around paper-dropdown-menu. 7 * `cr-dropdown-menu` is a Chrome-specific wrapper around paper-dropdown-menu.
stevenjb 2015/03/06 17:39:15 Is this a Polymer convention or a Closure one? I d
michaelpg 2015/03/06 18:24:09 Polymer. The core-doc-viewer will format this as c
8 * It includes a paper-dropdown so its content should just be a core-menu and 8 * It includes a paper-dropdown so its content should just be a core-menu and
9 * items. 9 * items.
10 * 10 *
11 * Example: 11 * Example:
12 * <cr-dropdown-menu> 12 * <cr-dropdown-menu>
13 * <core-menu> 13 * <core-menu>
14 * <paper-item>Chrome</paper-item> 14 * <paper-item>Chrome</paper-item>
15 * <paper-item>Firefox</paper-item> 15 * <paper-item>Firefox</paper-item>
16 * <paper-item>IE</paper-item> 16 * <paper-item>IE</paper-item>
17 * <paper-item>Opera</paper-item> 17 * <paper-item>Opera</paper-item>
(...skipping 25 matching lines...) Expand all
43 label: '<Dropdown Menu Label>', 43 label: '<Dropdown Menu Label>',
44 }, 44 },
45 45
46 /** @override */ 46 /** @override */
47 domReady: function() { 47 domReady: function() {
48 assert( 48 assert(
49 this.querySelector('.menu'), 49 this.querySelector('.menu'),
50 'cr-dropdown-menu must have a menu child with class="menu".'); 50 'cr-dropdown-menu must have a menu child with class="menu".');
51 }, 51 },
52 }); 52 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698