lib/parser.dart - Issue 987433005: remove most string concat, fixes #7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/parser.dart

Issue 987433005: remove most string concat, fixes #7 (Closed) Base URL: git@github.com:dart-lang/html.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/parser.dart

diff --git a/lib/parser.dart b/lib/parser.dart

index 860f3be6e430c56e26300aa0081009be182c7802..d81f88875ee3957a838708361a83779839f7953c 100644

--- a/lib/parser.dart

+++ b/lib/parser.dart

@@ -3395,7 +3395,7 @@ class InForeignContentPhase extends Phase {

Token processCharacters(CharactersToken token) {

if (token.data == "\u0000") {

- token.data = "\uFFFD";

+ token.replaceData("\uFFFD");

} else if (parser.framesetOK && !allWhitespace(token.data)) {

parser.framesetOK = false;

}

« no previous file with comments | « lib/dom.dart ('k') | lib/src/token.dart » ('j') | lib/src/tokenizer.dart » ('J')