Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 98743002: Count usage of the obsolete 'isindex' element. (Closed)

Created:
7 years ago by Mike West
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Count usage of the obsolete 'isindex' element. I can imagine wanting to count other element types as well; I've implemented this CL with that in mind, by putting the UseCounter getter on the parser so that we can grab it from anything involved with parsing rather than sticking it somewhere in the tree-builder. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163074

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike West
Mind taking a look at this, Ojan? -mike
7 years ago (2013-12-02 20:59:48 UTC) #1
ojan
I'd rather someone more familiar with the parser review this. Adam, Eric?
7 years ago (2013-12-02 21:04:30 UTC) #2
eseidel
This seems fine to me. lgtm.
7 years ago (2013-12-02 21:06:03 UTC) #3
Mike West
On 2013/12/02 21:06:03, eseidel wrote: > This seems fine to me. lgtm. Thanks to you ...
7 years ago (2013-12-02 21:13:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/98743002/1
7 years ago (2013-12-02 21:13:26 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-02 21:13:28 UTC) #6
Mike West
On 2013/12/02 21:13:28, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
7 years ago (2013-12-02 21:14:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/98743002/20001
7 years ago (2013-12-03 08:20:39 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-03 09:59:23 UTC) #9
Message was sent while issue was closed.
Change committed as 163074

Powered by Google App Engine
This is Rietveld 408576698