Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 987373002: Adds a boolean to indicate if v8 should use the correct architecture (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a boolean to indicate if v8 should use the correct architecture This is needed so that I can land patches straddling the v8 and chrome repos. BUG=465456 TEST=none R=jochen@chromium.org Committed: https://crrev.com/d4b61b40e3f5568f599f944ee93294ce8af62348 Cr-Commit-Position: refs/heads/master@{#319899}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/module_args/v8.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
5 years, 9 months ago (2015-03-10 16:10:01 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-10 16:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987373002/20001
5 years, 9 months ago (2015-03-10 16:16:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 16:42:22 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 16:43:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4b61b40e3f5568f599f944ee93294ce8af62348
Cr-Commit-Position: refs/heads/master@{#319899}

Powered by Google App Engine
This is Rietveld 408576698