Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 987363002: DevTools: fix injectedscriptsource compilation. (Closed)

Created:
5 years, 9 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
kozy, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix injectedscriptsource compilation. TBR=yurys NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191634

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/inspector/InjectedScriptSource.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/scripts/check_injected_script_source.py View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
pfeldman
5 years, 9 months ago (2015-03-10 14:56:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987363002/1
5 years, 9 months ago (2015-03-10 14:58:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191634
5 years, 9 months ago (2015-03-10 14:58:47 UTC) #4
kozy
4 years, 4 months ago (2016-08-10 17:17:11 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/987363002/diff/1/Source/devtools/scripts/chec...
File Source/devtools/scripts/check_injected_script_source.py (right):

https://codereview.chromium.org/987363002/diff/1/Source/devtools/scripts/chec...
Source/devtools/scripts/check_injected_script_source.py:66: if
line.find("suppressBlacklist"):
find in python returns -1 if not found :(

Powered by Google App Engine
This is Rietveld 408576698