Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 98733002: Avoid using non-standard property names in test (Closed)

Created:
7 years ago by davve
Modified:
7 years ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid using non-standard property names in test For bug 290055, two use counters was added for how CSSStyleDeclaration is indexed. One is using non-standard literal names for the CSS properties, i.e using elt.style['font-size'] instead of elt.style['fontSize']. The other one is using 'float' instead of 'cssFloat'. Avoid measuring the use counter code in performance tests by using the standard names instead. BUG=313864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M PerformanceTests/CSS/CSSPropertySetterGetter.html View 2 chunks +2 lines, -2 lines 0 comments Download
M PerformanceTests/CSS/CSSPropertyUpdateValue.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davve
Part of an effort to make PerformanceTests/CSS/CSSPropertyUpdateValue.html less affected by added use counters (in https://codereview.chromium.org/47923015/). ...
7 years ago (2013-12-02 09:51:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-02 10:18:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/98733002/1
7 years ago (2013-12-02 10:54:07 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 11:47:12 UTC) #4
Message was sent while issue was closed.
Change committed as 162981

Powered by Google App Engine
This is Rietveld 408576698