Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm

Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test size of web contents, not content view. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm
diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm b/chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm
index 4920ac74158f2413895398431c6941d2fa0f5a15..72831431deb6a9531aa85f4cb6a07129ec88c732 100644
--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm
+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm
@@ -5,6 +5,7 @@
#import "chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.h"
#include "chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h"
+#import "chrome/browser/ui/views/apps/app_window_native_widget_mac.h"
tapted 2015/03/18 00:06:39 nit: import->include
jackhou1 2015/03/18 03:44:39 Done.
ChromeNativeAppWindowViewsMac::ChromeNativeAppWindowViewsMac()
: is_hidden_with_app_(false) {
@@ -13,6 +14,15 @@ ChromeNativeAppWindowViewsMac::ChromeNativeAppWindowViewsMac()
ChromeNativeAppWindowViewsMac::~ChromeNativeAppWindowViewsMac() {
}
+void ChromeNativeAppWindowViewsMac::OnBeforeWidgetInit(
+ const extensions::AppWindow::CreateParams& create_params,
+ views::Widget::InitParams* init_params,
+ views::Widget* widget) {
+ init_params->native_widget = new AppWindowNativeWidgetMac(widget);
tapted 2015/03/18 00:06:39 DCHECK(!init_params->native_widget); i.e. ensure
jackhou1 2015/03/18 03:44:39 Done.
+ ChromeNativeAppWindowViews::OnBeforeWidgetInit(create_params, init_params,
+ widget);
+}
+
void ChromeNativeAppWindowViewsMac::Show() {
if (is_hidden_with_app_) {
// If there is a shim to gently request attention, return here. Otherwise

Powered by Google App Engine
This is Rietveld 408576698