Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: chrome/browser/ui/views/apps/app_window_native_widget_mac.mm

Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test size of web contents, not content view. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
diff --git a/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm b/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
new file mode 100644
index 0000000000000000000000000000000000000000..018c471c30c4f6c6957954ae84de0319fffb7017
--- /dev/null
+++ b/chrome/browser/ui/views/apps/app_window_native_widget_mac.mm
@@ -0,0 +1,32 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/apps/app_window_native_widget_mac.h"
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/base/cocoa/window_size_constants.h"
+#import "ui/views/cocoa/native_widget_mac_nswindow.h"
+
+AppWindowNativeWidgetMac::AppWindowNativeWidgetMac(views::Widget* widget)
+ : NativeWidgetMac(widget) {
+}
+
+AppWindowNativeWidgetMac::~AppWindowNativeWidgetMac() {
+}
+
+NSWindow* AppWindowNativeWidgetMac::CreateNSWindow(
+ views::Widget::InitParams params) {
+ if (!params.remove_standard_frame)
tapted 2015/03/18 00:06:39 comment about this? (i.e. what native app window w
jackhou1 2015/03/18 03:44:39 Done.
+ return NativeWidgetMac::CreateNSWindow(params);
+
+ NSUInteger style_mask = NSTexturedBackgroundWindowMask | NSTitledWindowMask |
tapted 2015/03/18 00:06:38 comment why NSTexturedBackgroundWindowMask is need
jackhou1 2015/03/18 03:44:39 Done.
+ NSClosableWindowMask | NSMiniaturizableWindowMask |
+ NSResizableWindowMask;
+ return [[NativeWidgetMacFramelessNSWindow alloc]
+ initWithContentRect:ui::kWindowSizeDeterminedLater
+ styleMask:style_mask
+ backing:NSBackingStoreBuffered
+ defer:YES];
tapted 2015/03/18 00:06:39 Returns from functions are typically autoreleased
jackhou1 2015/03/18 03:44:39 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698