ui/views/cocoa/native_widget_mac_nswindow.h - Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/cocoa/native_widget_mac_nswindow.h

Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test size of web contents, not content view. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_	5 #ifndef UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_

6 #define UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_	6 #define UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 #include "ui/views/views_export.h"	10 #include "ui/views/views_export.h"

11	11

12 // The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that	12 // The NSWindow used by BridgedNativeWidget. Provides hooks into AppKit that

13 // can only be accomplished by overriding methods.	13 // can only be accomplished by overriding methods.

14 VIEWS_EXPORT	14 VIEWS_EXPORT

15 @interface NativeWidgetMacNSWindow : NSWindow	15 @interface NativeWidgetMacNSWindow : NSWindow

16 @end	16 @end

17	17

	18 // Overrides contentRect <-> frameRect conversion methods to keep them equal to

	19 // each other.
	tapted 2015/03/18 00:06:39 add (e.g.) ", even for windows that do not use NSB add (e.g.) ", even for windows that do not use NSBorderlessWindowMask. This allows an NSWindow to be frameless without attaining undesired side-effects of NSBorderlessWindowMask. jackhou1 2015/03/18 03:44:39 Done. Show quoted text On 2015/03/18 00:06:39, tapted wrote: > add (e.g.) ", even for windows that do not use NSBorderlessWindowMask. This > allows an NSWindow > to be frameless without attaining undesired side-effects of > NSBorderlessWindowMask. Done.
	20 VIEWS_EXPORT

	21 @interface NativeWidgetMacFramelessNSWindow : NativeWidgetMacNSWindow
	tapted 2015/03/18 00:06:39 This is only used in chrome/browser/ui/views/apps/ This is only used in chrome/browser/ui/views/apps/ so it should be in a separate file there. (If we also use it for browser windows in future we can move it to, e.g., chrome/browser/ui/views/mac or something) jackhou1 2015/03/18 03:44:39 Done. Show quoted text On 2015/03/18 00:06:39, tapted wrote: > This is only used in chrome/browser/ui/views/apps/ so it should be in a separate > file there. > > (If we also use it for browser windows in future we can move it to, e.g., > chrome/browser/ui/views/mac or something) Done.
	22 @end

	23

18 #endif // UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_	24 #endif // UI_VIEWS_COCOA_NATIVE_WIDGET_MAC_NSWINDOW_H_

OLD	NEW