[MacViews] Frameless app windows: make content view cover title bar.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
 #include "ui/base/ime/text_input_client.h"
@@ skipping 230 matching lines @@
              domCode:ui::DomCode::KEY_A
           eventFlags:ui::EF_CONTROL_DOWN];
 }
 
 // NSView implementation.
 
 - (BOOL)acceptsFirstResponder {
   return YES;
 }
 
+- (void)viewDidMoveToWindow {
+  // When this view is added to a window, AppKit calls setFrameSize before it is

[jackhou1, 2015/03/13 23:32:55]

Overriding viewDidMoveToWindow is one option. I like it because it puts the code
right next to setFrameSize below. We could instead override setContentView in
NativeWidgetMacFramelessNSWindow, or call setFrameSize at the end of
BridgedNativeWidget::SetRootView(). WDYT?

[tapted, 2015/03/18 00:06:39]

Yeah I like this.

+  // added to the window, so the behavior in setFrameSize is not triggered.
+  NSWindow* window = [self window];
+  if (window)
+    [self setFrameSize:NSZeroSize];
+}
+
 - (void)setFrameSize:(NSSize)newSize {
+  // The size passed in here does not always use
+  // -[NSWindow contentRectForFrameRect].

[tapted, 2015/03/18 00:06:39]

This needs a comment like

The following ensures that the contentView for a frameless window can extend
over the titlebar of the new window containing it, since AppKit requires a
titlebar to give frameless windows correct shadows and rounded corners.

[jackhou1, 2015/03/18 03:44:39]

Done.

+  NSWindow* window = [self window];
+  if (window)
+    newSize = [window contentRectForFrameRect:[window frame]].size;
+
   [super setFrameSize:newSize];
   if (!hostedView_)
     return;
 
   hostedView_->SetSize(gfx::Size(newSize.width, newSize.height));
 }
 
 - (void)drawRect:(NSRect)dirtyRect {
   // Note that BridgedNativeWidget uses -[NSWindow setAutodisplay:NO] to
   // suppress calls to this when the window is known to be hidden.
@@ skipping 441 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end