chrome/browser/ui/views/apps/app_window_native_widget_mac.h - Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/apps/app_window_native_widget_mac.h

Issue 987323002: [MacViews] Frameless app windows: make content view cover title bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test size of web contents, not content view. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm ('K') | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm ('k') | chrome/browser/ui/views/apps/app_window_native_widget_mac.mm » ('j') | chrome/browser/ui/views/apps/app_window_native_widget_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_VIEWS_APPS_APP_WINDOW_NATIVE_WIDGET_MAC_H

	6 #define CHROME_BROWSER_UI_VIEWS_APPS_APP_WINDOW_NATIVE_WIDGET_MAC_H

	7

	8 #include "ui/views/widget/native_widget_mac.h"

	9

	10 class AppWindowNativeWidgetMac : public views::NativeWidgetMac {
	tapted 2015/03/18 00:06:38 needs a class comment needs a class comment jackhou1 2015/03/18 03:44:39 Done. Show quoted text On 2015/03/18 00:06:38, tapted wrote: > needs a class comment Done.
	11 public:

	12 AppWindowNativeWidgetMac(views::Widget* widget);
	tapted 2015/03/18 00:06:38 explicit explicit jackhou1 2015/03/18 03:44:39 Done. Show quoted text On 2015/03/18 00:06:38, tapted wrote: > explicit Done.
	13 ~AppWindowNativeWidgetMac() override;

	14

	15 protected:

	16 // NativeWidgetMac:

	17 NSWindow* CreateNSWindow(views::Widget::InitParams params) override;
	tapted 2015/03/18 00:06:38 pass \|params\| by const reference? Also the return pass \|params\| by const reference? Also the return type should be gfx::NativeWindow since this (and native_widget_mac.h) should look like C++-only headers (i.e. no obj-C allowed) jackhou1 2015/03/18 03:44:39 Done. Show quoted text On 2015/03/18 00:06:38, tapted wrote: > pass \|params\| by const reference? Also the return type should be > gfx::NativeWindow since this (and native_widget_mac.h) should look like C++-only > headers (i.e. no obj-C allowed) Done.
	18

	19 private:

	20 DISALLOW_COPY_AND_ASSIGN(AppWindowNativeWidgetMac);

	21 };

	22

	23 #endif // CHROME_BROWSER_UI_VIEWS_APPS_APP_WINDOW_NATIVE_WIDGET_MAC_H

OLD	NEW