[MacViews] Frameless app windows: make content view cover title bar.

chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file tests whichever implementation of NativeAppWindow is used.
 // I.e. it could be NativeAppWindowCocoa or ChromeNativeAppWindowViewsMac.
 #include "extensions/browser/app_window/native_app_window.h"
 
 #import <Cocoa/Cocoa.h>
 
@@ skipping 195 matching lines @@
   watcher.reset([[ScopedNotificationWatcher alloc]
       initWithNotification:NSWindowDidExitFullScreenNotification
                  andObject:ns_window]);
   [ns_window toggleFullScreen:nil];
   [watcher waitForNotification];
   EXPECT_EQ(extensions::AppWindow::FULLSCREEN_TYPE_NONE,
             app_window->fullscreen_types_for_test());
   EXPECT_FALSE(window->IsFullscreen());
   EXPECT_FALSE([ns_window styleMask] & NSFullScreenWindowMask);
 }
+
+// Test that, in frameless windows, the web contents has the same size as the
+// window.
+IN_PROC_BROWSER_TEST_F(NativeAppWindowCocoaBrowserTest, Frameless) {
+  extensions::AppWindow* app_window =
+      CreateTestAppWindow("{\"frame\": \"none\"}");
+  NSWindow* ns_window = app_window->GetNativeWindow();
+  NSView* web_contents = app_window->web_contents()->GetNativeView();
+  EXPECT_TRUE(NSEqualSizes([ns_window frame].size, [web_contents frame].size));
+  // Move and resize the window.
+  [ns_window setFrame:NSMakeRect(50, 50, 200, 200) display:YES];

[tapted, 2015/03/18 00:06:38]

can you add a check that ensures this wasn't simply a no-op?

I think we can safely rely on the size being non-flaky. So, e.g., check the
frame size equals the expected default size for the app window api before, and
check after against the 200x200 constant

[jackhou1, 2015/03/18 03:44:39]

Done.

+  EXPECT_TRUE(NSEqualSizes([ns_window frame].size, [web_contents frame].size));
+  CloseAppWindow(app_window);
+}

[tapted, 2015/03/18 00:06:38]

I think there are some other things this CL fixes which are easy to check here.
E.g.

// Windows created with NSBorderlessWindowMask by default don't have shadow, but
// packaged apps should always have one.
EXPECT_TRUE([ns_window hasShadow]);


(anything else?)

[jackhou1, 2015/03/18 03:44:39]

Done.